Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release v0.5.0 #270

Merged
merged 25 commits into from
May 15, 2024
Merged

release v0.5.0 #270

merged 25 commits into from
May 15, 2024

Conversation

trz42
Copy link
Contributor

@trz42 trz42 commented May 15, 2024

Includes

Improvements:

truib and others added 25 commits March 12, 2024 11:08
update authors and headers where applicable
- defines a number of constant strings (to be used in tasks/deploy.py)
- defines a new function determine_job_id_from_job_directory
- defines a new function get_section_from_file
- removes function read_job_metadata_from_file (calls to be replaced by
  get_section_from_file)
- includes numerous related changes
- uses job_metadata.get_section_from_file to read job metadata and return PR
  section
- renames determine_eessi_tarballs to determine_artefacts
  - uses _bot_jobSLURM_JOBID.result file to obtain artefacts
  - it relies on what the script bot/check-build.sh in the target GitHub
    repository determines as artefacts, thus it does need to know anything about
    the target GitHub repository
- renames check_build_status to check_job_status
  - completely overhauled logic which essentially relies on the value of the
    status attribute in the _bot_jobSLURM_JOBID.result file
  - it relies on what the script bot/check-build.sh in the target GitHub
    repository determines as status, thus it does need to know anything about
    the target GitHub repository
- renames upload_tarball to upload_artefact
  - no changes of logic
  - mostly renamed 'tarball' to 'artefact' (except for tarball_prefix* related
    variables; these might be changed in a later PR; a change would also require
    changes to the configurations, app.cfg.example and README.md)
  - also changed 'build_target' to 'payload' and made clear that
    'eessi-VERSION-COMPONENT-OS-ARCH' is just format used within EESSI to
    describe the contents of a payload (or build_target)
- updated uploaded_before
  - no changes of logic
  - uses 'payload' instead of 'build_target'
- updated determine_successful_jobs
  - removes unnecessary function calls: determine_slurm_out
  - removes unnecessary key/value pair in job dictionary: 'slurm_out'
  - switches to using 'artefact' instead of 'eessi_tarball' for variables and
    functions (determine_artefacts)
  - uses renamed and overhauled check_job_status
  - minor polishing of log messages: 'build' -> 'job'
- renames determine_tarballs_to_deploy to determine_artefacts_to_deploy
  - removes mentioning of 'slurm_out' data in job dictionary (docstring)
  - rephrases 'build*target' to 'payload' (docstring)
  - rephrases '(built/eessi) tarballs' to 'artefacts' (docstring, variables, log
    messages)
  - renames 'tb0' to 'artefact'
- updated deploy_built_artefacts
  - uses determine_artefacts_to_deploy instead of determine_tarballs_to_deploy
  - rephrases 'target' to 'payload'
  - uses upload_artefact instead of upload_tarball
- file 'tools/job_metadata.py'
  - add constant for 'TEST' section

- file 'eessi_bot_job_manager.py'
  - replace read_job_metadata_from_file, read_job_test and read_job_result with get_section_from_file
  - some polishing: changing imports, removing unused functions

- file 'tests/test_tools_job_metadata.py'
  - replaced read_job_metadata_from_file with get_section_from_file
  - updated log file name accordingly
- string constants being used have been defined in the correct modules
  - when they are used they have to be prefixed with the module, hence
    it becomes more clear to which module they belong
- a new file tools/cvmfs_repository.py for constants used for the settings of a
  CernVM-FS repository is added
- both the event handler and job manager verify at the start that
  required/recommended settings are defined in 'app.cfg'
…config

reorganisation of constants and validation of config settings
Copy link
Member

@Neves-P Neves-P left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to go! 🚀

@Neves-P Neves-P merged commit a5b40e9 into main May 15, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants