Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement exportvariable filter #288

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Conversation

smoors
Copy link
Contributor

@smoors smoors commented Nov 10, 2024

fixes #281

this implements the approach suggested by @boegel in the issue: if the filter is specified in a comment, file bot/export_vars.sh is created and sourced before running the bot/build.sh script

notes:

  • as is the case with other filters, spaces or colons cannot be used
  • variables have to be specified one by one, which was easier to implement and avoids having to specify another delimiter, which then also cannot be used
  • i used filter name exportvariable instead of the suggested build_env to avoid confusion with other uses of build_env in the code.

example usage:

bot: build arch:zen4 export:MYVAR1=myval1 export:MYVAR2=myval2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

export environment variables with a "bot: build" comment
1 participant