-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update ingestion script to support multiple S3 buckets #154
Conversation
if args.list_only: | ||
for num, tarball in enumerate(tarballs): | ||
print(f'{num}: {tarball}') | ||
sys.exit(0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was already a bit ugly, but doesn't work as intended anymore at all now, as it will exit before the second bucket is being handled. Easy fix would be to change it in continue
, but maybe it should be done a bit cleaner with a proper if
/else
or something
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed in aed065a
Gave it a quick try, and the new code seems to work fine, except that there is a bug in the existing
|
This can actually be easily fixed by using:
|
fixed in cc63131 |
OK, see ddef0c7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm. One failing CI test, but that's completely unrelated to the changes made in this PR, so I'm ignoring it.
opened an issue for CI problem: #155 |
No description provided.