-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clean up local tmp if it has been saved to a tarball #267
base: 2023.06-software.eessi.io
Are you sure you want to change the base?
Conversation
Instance
|
bot: show_config |
Updates by the bot instance
|
Updates by the bot instance
|
Instance
|
Instance
|
bot: show_help |
Updates by the bot instance
|
Updates by the bot instance
|
bot: show_config |
Updates by the bot instance
|
Updates by the bot instance
|
Instance
|
Instance
|
bot: show_config |
Updates by the bot instance
|
Updates by the bot instance
|
Instance
|
Instance
|
{2023.06}[foss/2023a] TensorFlow v2.13.0
# double-check that at least one tarball of the temporary storage was created | ||
if check_tmp_tarball ${TARBALL_TMP_BUILD_STEP_DIR} || check_tmp_tarball ${TARBALL_TMP_TARBALL_STEP_DIR}; then | ||
echo "Removing temporary storage under '${STORAGE}'" | ||
rm -rf ${STORAGE} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I understand things correctly, $STORAGE
refers to the base directory where all jobs create their unique subdirectory? In that case, shouldn't we only remove ${JOB_STORAGE}
here, as there may be other (running) jobs on the same machine?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think, that's right.
Surprisingly, this ${JOB_STORAGE}
is just created (a subdirectory under ${STORAGE}
) but it is never used.
We should do two things
- replace uses of
${STORAGE}
by${JOB_STORAGE}
when runningeessi_container.sh
and test properly if that still works (maybe a separate PR would be beneficial) - replace uses of
${STORAGE}
by${JOB_STORAGE}
in this PR here such that only job specific job temporary storage is removed
The
bot/build.sh
runseessi_container.sh
twice and each run results in a tarball containing the temporary folder. If a job runs on a machine where this temporary folder is not cleaned up automatically, disk usage can pile up leading to failing build jobs.This PR checks if a temporary folder is accessible (
${STORAGE}
). If so it removes it if there is any tarball created for it.Improves situation that resulted in creating EESSI/eessi-bot-software-layer#186