Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump action versions #465

Merged
merged 2 commits into from
Jan 29, 2024

Conversation

trz42
Copy link
Collaborator

@trz42 trz42 commented Jan 27, 2024

This is to address warnings shown for CI workflows. Warnings look like

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@93ea575cb5d8a053eaa0ac8fa3b40d7e05a33cc8, actions/setup-python@13ae5bb136fac2878aff31522b9efb785519f984. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

@trz42 trz42 added tests Related to software testing 2023.06-software.eessi.io 2023.06 version of software.eessi.io labels Jan 27, 2024
Copy link

eessi-bot bot commented Jan 27, 2024

Instance eessi-bot-mc-aws is configured to build:

  • arch x86_64/generic for repo eessi-hpc.org-2023.06-compat
  • arch x86_64/generic for repo eessi-hpc.org-2023.06-software
  • arch x86_64/generic for repo eessi.io-2023.06-compat
  • arch x86_64/generic for repo eessi.io-2023.06-software
  • arch x86_64/intel/haswell for repo eessi-hpc.org-2023.06-compat
  • arch x86_64/intel/haswell for repo eessi-hpc.org-2023.06-software
  • arch x86_64/intel/haswell for repo eessi.io-2023.06-compat
  • arch x86_64/intel/haswell for repo eessi.io-2023.06-software
  • arch x86_64/intel/skylake_avx512 for repo eessi-hpc.org-2023.06-compat
  • arch x86_64/intel/skylake_avx512 for repo eessi-hpc.org-2023.06-software
  • arch x86_64/intel/skylake_avx512 for repo eessi.io-2023.06-compat
  • arch x86_64/intel/skylake_avx512 for repo eessi.io-2023.06-software
  • arch x86_64/amd/zen2 for repo eessi-hpc.org-2023.06-compat
  • arch x86_64/amd/zen2 for repo eessi-hpc.org-2023.06-software
  • arch x86_64/amd/zen2 for repo eessi.io-2023.06-compat
  • arch x86_64/amd/zen2 for repo eessi.io-2023.06-software
  • arch x86_64/amd/zen3 for repo eessi-hpc.org-2023.06-compat
  • arch x86_64/amd/zen3 for repo eessi-hpc.org-2023.06-software
  • arch x86_64/amd/zen3 for repo eessi.io-2023.06-compat
  • arch x86_64/amd/zen3 for repo eessi.io-2023.06-software
  • arch aarch64/generic for repo eessi-hpc.org-2023.06-compat
  • arch aarch64/generic for repo eessi-hpc.org-2023.06-software
  • arch aarch64/generic for repo eessi.io-2023.06-compat
  • arch aarch64/generic for repo eessi.io-2023.06-software
  • arch aarch64/neoverse_n1 for repo eessi-hpc.org-2023.06-compat
  • arch aarch64/neoverse_n1 for repo eessi-hpc.org-2023.06-software
  • arch aarch64/neoverse_n1 for repo eessi.io-2023.06-compat
  • arch aarch64/neoverse_n1 for repo eessi.io-2023.06-software
  • arch aarch64/neoverse_v1 for repo eessi-hpc.org-2023.06-compat
  • arch aarch64/neoverse_v1 for repo eessi-hpc.org-2023.06-software
  • arch aarch64/neoverse_v1 for repo eessi.io-2023.06-compat
  • arch aarch64/neoverse_v1 for repo eessi.io-2023.06-software

@trz42
Copy link
Collaborator Author

trz42 commented Jan 28, 2024

Two actions failing with

Error: .github#L1

cvmfs-contrib/github-action-cvmfs@55899ca74cf78ab874bdf47f5a804e47c198743c is not allowed to be used in EESSI/software-layer. Actions in this workflow must be: within a repository owned by EESSI, created by GitHub, or matching the following: ossf/scorecard-action@99c53751e09b9529366343771cc321ec74e9bd3d, cvmfs-contrib/github-action-cvmfs@d4641d0d591c9a5c3be23835ced2fb648b44c04b, ansible/ansible-lint-action@27c37f9001153675ee6abcadcd722bcbdafaba08, robinraju/release-downloader@d6de084c58345d09b017e22701dbcf26977cfd14, codespell-project/actions-codespell@22ff5a2e4b591290baf82d47c9feadac31c65441, ibiqlik/action-yamllint@2576378a8e339169678f9939646ee3ee325e845c, pkgcore/pkgcheck-action@5a0413f4494d00e286fb7cf6b8388b6c4578afa4, bpicode/github-action-fpm@e76c0e2166030f4691d641a700b16958c7d12f5d, meeDamian/github-release@7ae19492500104f636b3fee4d8103af0fed36c8e, dev-drprasad/delete-tag-and-release@085c6969f18bad0de1b9f3fe6692a3cd01f64fe5, rtCamp/action-slack-notify@12e36fc18b0689399306c2e0...

@boegel boegel merged commit 1045ef0 into EESSI:2023.06-software.eessi.io Jan 29, 2024
18 checks passed
@boegel
Copy link
Contributor

boegel commented Jan 29, 2024

Two actions failing with

Error: .github#L1

cvmfs-contrib/github-action-cvmfs@55899ca74cf78ab874bdf47f5a804e47c198743c is not allowed to be used in EESSI/software-layer. Actions in this workflow must be: within a repository owned by EESSI, created by GitHub, or matching the following: ossf/scorecard-action@99c53751e09b9529366343771cc321ec74e9bd3d, cvmfs-contrib/github-action-cvmfs@d4641d0d591c9a5c3be23835ced2fb648b44c04b, ansible/ansible-lint-action@27c37f9001153675ee6abcadcd722bcbdafaba08, robinraju/release-downloader@d6de084c58345d09b017e22701dbcf26977cfd14, codespell-project/actions-codespell@22ff5a2e4b591290baf82d47c9feadac31c65441, ibiqlik/action-yamllint@2576378a8e339169678f9939646ee3ee325e845c, pkgcore/pkgcheck-action@5a0413f4494d00e286fb7cf6b8388b6c4578afa4, bpicode/github-action-fpm@e76c0e2166030f4691d641a700b16958c7d12f5d, meeDamian/github-release@7ae19492500104f636b3fee4d8103af0fed36c8e, dev-drprasad/delete-tag-and-release@085c6969f18bad0de1b9f3fe6692a3cd01f64fe5, rtCamp/action-slack-notify@12e36fc18b0689399306c2e0...

Two workflows are failing now because of this after the merge (unclear why they didn't fail when the workflows were run for this PR): .github/workflows/test-software.eessi.io.yml + .github/workflows/tests_archdetect.yml.

@ocaisa Do you know where the whitelisting is done, since cvmfs-contrib/github-action-cvmfs@d4641d0d591c9a5c3be23835ced2fb648b44c04b is being listed as allowed (we updated to cvmfs-contrib/github-action-cvmfs@55899ca74cf78ab874bdf47f5a804e47c198743c in this PR)?

@boegel
Copy link
Contributor

boegel commented Jan 29, 2024

Ah, found it, that's configured at https://github.com/organizations/EESSI/settings/actions, see Allow specified actions and reusable workflows.

@trz42
Copy link
Collaborator Author

trz42 commented Jan 29, 2024

Ah, found it, that's configured at https://github.com/organizations/EESSI/settings/actions, see Allow specified actions and reusable workflows.

Nice. Was really curious where that is defined.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2023.06-software.eessi.io 2023.06 version of software.eessi.io tests Related to software testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants