Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow initialisation scripts to be used with bash < 4.2 #643

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

ocaisa
Copy link
Member

@ocaisa ocaisa commented Jul 17, 2024

If using a CentOS6 bash you get

-bash: /cvmfs/software.eessi.io/versions/2023.06/init/bash: line 4: conditional binary operator expected
-bash: /cvmfs/software.eessi.io/versions/2023.06/init/bash: line 4: syntax error near `EESSI_SILENT'
-bash: /cvmfs/software.eessi.io/versions/2023.06/init/bash: line 4: `  if [[ ! -v EESSI_SILENT ]]; then'

-v was introduced in Bash 4.2, but it's not hard for us to improve our backwards compatibility

Copy link

eessi-bot bot commented Jul 17, 2024

Instance eessi-bot-mc-aws is configured to build for:

  • architectures: x86_64/generic, x86_64/intel/haswell, x86_64/intel/skylake_avx512, x86_64/amd/zen2, x86_64/amd/zen3, aarch64/generic, aarch64/neoverse_n1, aarch64/neoverse_v1
  • repositories: eessi.io-2023.06-compat, eessi-hpc.org-2023.06-software, eessi-hpc.org-2023.06-compat, eessi.io-2023.06-software

Copy link

eessi-bot bot commented Jul 17, 2024

Instance eessi-bot-mc-azure is configured to build for:

  • architectures: x86_64/amd/zen4
  • repositories: eessi-hpc.org-2023.06-compat, eessi-hpc.org-2023.06-software, eessi.io-2023.06-software, eessi.io-2023.06-compat

@ocaisa
Copy link
Member Author

ocaisa commented Jul 17, 2024

Tested with bash 3.2.57

@ocaisa
Copy link
Member Author

ocaisa commented Jul 17, 2024

bot: build repo:eessi.io-2023.06-software arch:x86_64/generic

Copy link

eessi-bot bot commented Jul 17, 2024

Updates by the bot instance eessi-bot-mc-aws (click for details)
  • received bot command build repo:eessi.io-2023.06-software arch:x86_64/generic from ocaisa

    • expanded format: build repository:eessi.io-2023.06-software architecture:x86_64/generic
  • handling command build repository:eessi.io-2023.06-software architecture:x86_64/generic resulted in:

Copy link

eessi-bot bot commented Jul 17, 2024

Updates by the bot instance eessi-bot-mc-azure (click for details)
  • received bot command build repo:eessi.io-2023.06-software arch:x86_64/generic from ocaisa

    • expanded format: build repository:eessi.io-2023.06-software architecture:x86_64/generic
  • handling command build repository:eessi.io-2023.06-software architecture:x86_64/generic resulted in:

    • no jobs were submitted

Copy link

eessi-bot bot commented Jul 17, 2024

New job on instance eessi-bot-mc-aws for architecture x86_64-generic for repository eessi.io-2023.06-software in job dir /project/def-users/SHARED/jobs/2024.07/pr_643/14605

date job status comment
Jul 17 12:13:59 UTC 2024 submitted job id 14605 awaits release by job manager
Jul 17 12:14:59 UTC 2024 released job awaits launch by Slurm scheduler
Jul 17 12:20:48 UTC 2024 running job 14605 is running
Jul 17 12:32:28 UTC 2024 finished
😁 SUCCESS (click triangle for details)
Details
✅ job output file slurm-14605.out
✅ no message matching ERROR:
✅ no message matching FAILED:
✅ no message matching required modules missing:
✅ found message(s) matching No missing installations
✅ found message matching .tar.gz created!
Artefacts
eessi-2023.06-software-linux-x86_64-generic-1721218836.tar.gzsize: 0 MiB (3035 bytes)
entries: 3
modules under 2023.06/software/linux/x86_64/generic/modules/all
no module files in tarball
software under 2023.06/software/linux/x86_64/generic/software
no software packages in tarball
other under 2023.06/software/linux/x86_64/generic
2023.06/init/bash
2023.06/init/eessi_defaults
2023.06/init/eessi_environment_variables
Jul 17 12:32:28 UTC 2024 test result
😁 SUCCESS (click triangle for details)
ReFrame Summary
[ PASSED ] Ran 14/14 test case(s) from 14 check(s) (0 failure(s), 0 skipped, 0 aborted)
Details
✅ job output file slurm-14605.out
✅ no message matching ERROR:
✅ no message matching [\s*FAILED\s*].*Ran .* test case
Jul 18 12:39:29 UTC 2024 uploaded transfer of eessi-2023.06-software-linux-x86_64-generic-1721218836.tar.gz to S3 bucket succeeded

@ocaisa
Copy link
Member Author

ocaisa commented Jul 18, 2024

Probably worth a review but I will set the label anyway...

@ocaisa ocaisa added enhancement New feature or request ready-to-deploy Mark a PR as ready to deploy labels Jul 18, 2024
init/bash Show resolved Hide resolved
@bedroge bedroge added bot:deploy Ask bot to deploy missing software installations to EESSI and removed ready-to-deploy Mark a PR as ready to deploy labels Jul 18, 2024
@bedroge bedroge merged commit 6f75df3 into EESSI:2023.06-software.eessi.io Jul 18, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:deploy Ask bot to deploy missing software installations to EESSI enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants