Create status enum on action pages #602
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esoterik
commented
Aug 14, 2019
| @@ -14,7 +14,9 @@ def run | |||
|
|
|||
| filters.each do |f, val| | |||
| next unless valid_query?(f, val) | |||
| @relation = if NAMED_SCOPES.include? f | |||
| @relation = if ENUM_QUERY == f | |||
| relation.send f | |||
There was a problem hiding this comment.
this should send val, not the filter name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft for now -- this is more or less just a database migration and model level changes required to change status into an enum. It has not been extensively tested, so I suspect that there might be some other broken things or improvements to be made elsewhere!