Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rubocop and fix issues #915

Merged
merged 4 commits into from
May 9, 2024
Merged

Update rubocop and fix issues #915

merged 4 commits into from
May 9, 2024

Commits on Apr 10, 2024

  1. update rubocop config 

    see: #193
    @jparr
    jparr committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    7be5118 View commit details
    Browse the repository at this point in the history

  2. rubocop autofix of unnecessary inline cop disables 

    see: #193
    @jparr
    jparr committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    f9798cc View commit details
    Browse the repository at this point in the history

  3. Subclass ApplicationRecord per rubocop 

    This is recommended in rails 5+
https://www.rubydoc.info/gems/rubocop-rails/RuboCop/Cop/Rails/ApplicationRecord

Delete .rubocop_todo.yml
    @jparr
    jparr committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    4525716 View commit details
    Browse the repository at this point in the history

  4. Enable NewCops and fix

    @jparr
    jparr committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    ea38d35 View commit details
    Browse the repository at this point in the history