-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Misc modernization #919
Draft
jparr
wants to merge
13
commits into
2024-upgrades-main
Choose a base branch
from
jparr/913-misc-modernization
base: 2024-upgrades-main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Misc modernization #919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jparr
force-pushed
the
jparr/913-misc-modernization
branch
from
April 19, 2024 00:35
4911c0c
to
1660a7f
Compare
user rails_transactional_fixtures see: #913
Use devise helpers for login Use new rails type:system for capybara tests
prep for zetwerk autoloading
this uses new rails autoloader : zeitwerk
- larger window - faster exec
jparr
force-pushed
the
jparr/913-misc-modernization
branch
from
May 10, 2024 20:12
1660a7f
to
3ccf15d
Compare
I wonder if we shouldnt just go straight to rails 7 over here: #920 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #913
Draft until other PRs are merged - then rebase