Upgrade Ahoy to 4.2 #921
Merged
Upgrade Ahoy to 4.2 #921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is 2 major versions above what's on
masterright now, so worth giving it a closer review.I added some feature tests (
spec/features/ahoy.rb) to ensure we're only collecting what we were before, but they're a bit brittle...there's a timing issue where sometimes the event isn't fully persisted before we check expectations. Switching the expectation to be based on the user's page (where we show actions they've taken if they've enabled activity recording) might work, but we still have to check the DB exclusively for one of the cases so it's not a full fix.