Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Badger popup UI is cut off on the bottom in some locales #1077

Closed
pvsomebody opened this issue Dec 15, 2016 · 16 comments · May be fixed by #1445
Closed

Badger popup UI is cut off on the bottom in some locales #1077

pvsomebody opened this issue Dec 15, 2016 · 16 comments · May be fixed by #1445
Labels
bug Firefox translations ui User interface modifications; related to but not the same as the "ux" label

Comments

@pvsomebody
Copy link

pvsomebody commented Dec 15, 2016

Hi. The issue can be considered aesthetic now, since the button can still be clicked, and is now clipped only a little, and only on the domains that have a lot of trackers, but you asked to repost it if it happens after the update, so here.

screenshot2

@cooperq cooperq changed the title The lower-most button is still clipped a little on the most recent version of PrivacyBadger The lower-most button is still clipped a little on the most recent version of PrivacyBadger in RU localization Dec 16, 2016
@cooperq cooperq added enhancement ui User interface modifications; related to but not the same as the "ux" label help wanted labels Dec 16, 2016
@cooperq
Copy link
Contributor

cooperq commented Dec 16, 2016

Thank you for bringing this to our attention!

@airone506
Copy link

This issue does not seem to be limited to RU localization. See attached screenshot please.

Using Firefox 50.1.0 on Ubuntu. The Privacy Badger version is 2016.12.15.1.

pb-01

@Urides
Copy link
Contributor

Urides commented Apr 21, 2017

Hi,

It's even worse in the french version of PB. The donate text doesn't even appear when there are too many trackers listed (PB 2017.3.28 with Firefox 52.0.2 on Linux Mint).

uipb

Thanks for reading.

@ghostwords ghostwords changed the title The lower-most button is still clipped a little on the most recent version of PrivacyBadger in RU localization Badger popup UI is cut off on the bottom in some locales Apr 21, 2017
@boxer4
Copy link

boxer4 commented May 13, 2017

I believe I'm seeing the same thing in the en/US locale too after auto downloading the 5/9/2017 update. The popup window size does not increase beyond the size of the three buttons normally seen for me, so the buttons and everything else beyond does not show up. Bug #1252 has examples of what I see in en/US except the location is correct (like the ones in these other locales). I reverted back to the 3/22/2017 as I had a backup of this version which restored proper operation. Firefox 45.8.0/Linux.

@MTco
Copy link

MTco commented Jun 5, 2017

En/US here. v2017.5.9.

2017-06-05_privacy-badger_2017 5 9

@ghostwords
Copy link
Member

@MTco Which version of Firefox do you have?

@MTco @boxer4 Does the problem go away if you upgrade Firefox?

@boxer4
Copy link

boxer4 commented Jun 5, 2017

New Firefox ESR recently available from OS packager, PB 5.9.2017 seems to work properly with Firefox 52.1. Assuming there was a behavior change in Firefox between the ESRs.

@ghostwords
Copy link
Member

ghostwords commented Jun 5, 2017

Yep, there are several now-fixed Firefox WebExtensions-related bugs in the older ESR.

@MTco
Copy link

MTco commented Jun 5, 2017

@ghostwords Firefox 47 on lubuntu x86. Currently unable to upgrade.

@raspi

This comment has been minimized.

@ghostwords

This comment has been minimized.

@lemnis
Copy link
Contributor

lemnis commented Oct 26, 2017

This should not happen anymore since #1516, it should now add a scrollbar to the popup. Can people that had this particular issue confirm this?

@Urides
Copy link
Contributor

Urides commented Oct 27, 2017

I guess it's a way of solving the problem. It's not really aesthetic, but at least you can access all buttons. It would've probably been prettier to diminish the maximum number of tracker displayed by one (since that part already had a scrollbar) and have the three buttons in one piece.

Anyway, thank you ;-)

image

@lemnis
Copy link
Contributor

lemnis commented Oct 27, 2017

@Urides I agree, eventually #1445 will do that

@ghostwords
Copy link
Member

ghostwords commented May 19, 2020

This should no longer be an issue following #2479 and #2563.

Edit: To be clear, this could resurface in the future as the popup didn't actually get better at handling this sort of thing, we just reduced the amount of text at the top of the popup in all locales.

@pvsomebody
Copy link
Author

pvsomebody commented May 19, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Firefox translations ui User interface modifications; related to but not the same as the "ux" label
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants