Fix popup layout for overflow menu in Firefox #2158
Conversation
|
Can't repro the original issue on Ubuntu 18.04, but there's a different issue (both in this branch and in master): It would be awesome if we could get rid of the scroll bar on the side when we fix this issue. |
|
@bcyphers your popup seems to be normal width. At least on my system (macOS), if I pin the extension to the overflow menu (probably called only "menu" in earlier Firefox releases), the popup is shrunk, which caused some layout issues. About the scroll bar - do you want to reduce the content height basically, to have it fit without scrolling? |
|
Sorry for the delay. Yes, the issue I pointed out above is different, and the problem this PR is trying to address was never a problem on Ubuntu. It would be great if we could fix both problems with one PR, but maybe they're too unrelated. The original issue isn't fixed for me in Firefox on Windows 10: |
|
The popup is a bit larger on Windows so the media query wouldn't get applied - now it should work. |
There was a problem hiding this comment.
Looks good! everything works for me now.
Thank you so much for your contribution, @generalbrus !
|
The test failure here looks unrelated to the changes. @ghostwords have you seen this before? https://travis-ci.org/EFForg/privacybadger/jobs/428562652 |
|
The same test failed once (also with Firefox) in another PR: https://travis-ci.org/EFForg/privacybadger/builds/429624697. I don't remember seeing this before though. |
|
Hi @andresbase, could you check this PR on Firefox for Android please? There should be no changes. Would be great to confirm on Firefox/Chrome on macOS too; no changes to the popup in either browser by default, but the popup should be fully usable now when placed in the overflow menu on Firefox. |
|
@ghostwords I finally got the android test setup working, and this looks fine. |
Fix popup layout problems when opened in the overflow menu in Firefox.
|
Thanks again! |
|
#1120 seems to be fixed now. thank you! 👍 |
|
Please subscribe to #1077 for the clipped buttons bug. |
Fix #1120 by setting ad-hoc styles for the popup shown from the overflow menu.
One odd thing I've noticed, and maybe you can check if it happens to you as well: the first time the popup is opened from the overflow menu, the popup is wider than it should be and there is a blank space on the right. Screenshot:
From then on the popup is shown correctly.
Also, the problem is not present if the option "disable popup auto hide" is set. It looks like firefox is not updating the width of the popup fast enough.