set compiler to latest C++ standard

<LanguageStandard>stdcpplatest</LanguageStandard>
EMCECS · Mar 4, 2021 · 4f66ac0 · 4f66ac0
1 parent 0805752
commit 4f66ac0
Show file tree

Hide file tree

Showing 54 changed files with 101 additions and 77 deletions.
diff --git a/ECSUtil/CRWLock.cpp b/ECSUtil/CRWLock.cpp
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2017 - 2020, Dell Technologies, Inc. All Rights Reserved.
+ * Copyright (c) 2017 - 2021, Dell Technologies, Inc. All Rights Reserved.
  *
  * Licensed under the Apache License, Version 2.0 (the "License").
  * You may not use this file except in compliance with the License.

diff --git a/ECSUtil/CRWLock.h b/ECSUtil/CRWLock.h
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2017 - 2020, Dell Technologies, Inc. All Rights Reserved.
+ * Copyright (c) 2017 - 2021, Dell Technologies, Inc. All Rights Reserved.
  *
  * Licensed under the Apache License, Version 2.0 (the "License").
  * You may not use this file except in compliance with the License.

diff --git a/ECSUtil/CSharedQueue.cpp b/ECSUtil/CSharedQueue.cpp
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2017 - 2020, Dell Technologies, Inc. All Rights Reserved.
+ * Copyright (c) 2017 - 2021, Dell Technologies, Inc. All Rights Reserved.
  *
  * Licensed under the Apache License, Version 2.0 (the "License").
  * You may not use this file except in compliance with the License.

diff --git a/ECSUtil/CSharedQueue.h b/ECSUtil/CSharedQueue.h
@@ -181,25 +181,25 @@ namespace ecs_sdk
 			return list<T>::empty();
 		};
 
-		list<T>::reference front()
+		typename list<T>::reference front()
 		{	// return first element of mutable sequence
 			CRWLockAcquire lockQueue(const_cast<CRWLock*>(&rwlQueue), true);			// write lock
 			return list<T>::front();
 		}
 
-		list<T>::const_reference front() const
+		typename list<T>::const_reference front() const
 		{	// return first element of nonmutable sequence
 			CRWLockAcquire lockQueue(const_cast<CRWLock*>(&rwlQueue), false);			// read lock
 			return list<T>::front();
 		}
 
-		list<T>::reference back()
+		typename list<T>::reference back()
 		{	// return last element of mutable sequence
 			CRWLockAcquire lockQueue(const_cast<CRWLock*>(&rwlQueue), true);			// write lock
 			return list<T>::back();
 		}
 
-		list<T>::const_reference back() const
+		typename list<T>::const_reference back() const
 		{	// return last element of nonmutable sequence
 			CRWLockAcquire lockQueue(const_cast<CRWLock*>(&rwlQueue), false);			// read lock
 			return list<T>::back();

diff --git a/ECSUtil/CngAES_GCM.cpp b/ECSUtil/CngAES_GCM.cpp
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2017 - 2020, Dell Technologies, Inc. All Rights Reserved.
+ * Copyright (c) 2017 - 2021, Dell Technologies, Inc. All Rights Reserved.
  *
  * Licensed under the Apache License, Version 2.0 (the "License").
  * You may not use this file except in compliance with the License.

diff --git a/ECSUtil/CngAES_GCM.h b/ECSUtil/CngAES_GCM.h
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2017 - 2020, Dell Technologies, Inc. All Rights Reserved.
+ * Copyright (c) 2017 - 2021, Dell Technologies, Inc. All Rights Reserved.
  *
  * Licensed under the Apache License, Version 2.0 (the "License").
  * You may not use this file except in compliance with the License.

diff --git a/ECSUtil/DLLFUNC.H b/ECSUtil/DLLFUNC.H
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2017 - 2020, Dell Technologies, Inc. All Rights Reserved.
+ * Copyright (c) 2017 - 2021, Dell Technologies, Inc. All Rights Reserved.
  *
  * Licensed under the Apache License, Version 2.0 (the "License").
  * You may not use this file except in compliance with the License.

diff --git a/ECSUtil/ECSConnection.cpp b/ECSUtil/ECSConnection.cpp
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2017 - 2020, Dell Technologies, Inc. All Rights Reserved.
+ * Copyright (c) 2017 - 2021, Dell Technologies, Inc. All Rights Reserved.
  *
  * Licensed under the Apache License, Version 2.0 (the "License").
  * You may not use this file except in compliance with the License.
@@ -72,7 +72,7 @@ DWORD CECSConnection::dwMaxRetryCount(MaxRetryCount);				// max retries for HTTP
 DWORD CECSConnection::dwPauseBetweenRetries(500);					// pause between retries (millisec)
 DWORD CECSConnection::dwPauseAfter500Error(500);					// pause between retries after HTTP 500 error (millisec)
 
-static TCHAR *SystemMDInit[] =
+static LPCWSTR SystemMDInit[] =
 {
 	_T("ObjectName"),
 	_T("Owner"),

diff --git a/ECSUtil/ECSConnection.h b/ECSUtil/ECSConnection.h
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2017 - 2020, Dell Technologies, Inc. All Rights Reserved.
+ * Copyright (c) 2017 - 2021, Dell Technologies, Inc. All Rights Reserved.
  *
  * Licensed under the Apache License, Version 2.0 (the "License").
  * You may not use this file except in compliance with the License.
@@ -1042,7 +1042,7 @@ class ECSUTIL_EXT_CLASS CECSConnection
 		bool bComplete = false;						// set if the command has completed
 		bool bHandleCreated = false;				// WINHTTP_CALLBACK_STATUS_HANDLE_CREATED
 		bool bHandleClosing = false;				// WINHTTP_CALLBACK_STATUS_HANDLE_CLOSING
-		bool *pbCallbackRegistered = false;			// pointer to flag indicating the callback has been registered
+		bool *pbCallbackRegistered = nullptr;		// pointer to flag indicating the callback has been registered
 		bool bDisableSecureLog = false;				// if set, don't log security errors in the callback
 		BYTE *pReadData = nullptr;					// WINHTTP_CALLBACK_STATUS_READ_COMPLETE
 		CECSConnection *pHost = nullptr;			// allow access to the host record
@@ -1539,8 +1539,8 @@ class ECSUTIL_EXT_CLASS CECSConnection
 	static void SetGlobalHttpsProtocol(DWORD dwGlobalHttpsProtocolParam);
 	static void SetS3BucketListingMax(DWORD dwS3BucketListingMaxParam);
 	static void SetRetries(DWORD dwMaxRetryCountParam, DWORD dwPauseBetweenRetriesParam = 500, DWORD dwPauseAfter500ErrorParam = 500);
-	static DWORD CECSConnection::SetRootCertificate(const ECS_CERT_INFO& CertInfo, DWORD dwCertOpenFlags = CERT_STORE_OPEN_EXISTING_FLAG | CERT_SYSTEM_STORE_LOCAL_MACHINE, LPCTSTR pszStoreName = _T("Root"));
-	static CString CECSConnection::GetSecureErrorText(DWORD dwSecureError);
+	static DWORD SetRootCertificate(const ECS_CERT_INFO& CertInfo, DWORD dwCertOpenFlags = CERT_STORE_OPEN_EXISTING_FLAG | CERT_SYSTEM_STORE_LOCAL_MACHINE, LPCTSTR pszStoreName = _T("Root"));
+	static CString GetSecureErrorText(DWORD dwSecureError);
 	static CString FormatSecurityInfo(const WINHTTP_SECURITY_INFO& SecurityInfo);
 
 	static void SetInitialized(void);				// global initialized flag. must be called to set regular timeouts

diff --git a/ECSUtil/ECSGlobal.cpp b/ECSUtil/ECSGlobal.cpp
@@ -1,5 +1,5 @@
 /*
-* Copyright (c) 2017 - 2020, Dell Technologies, Inc. All Rights Reserved.
+* Copyright (c) 2017 - 2021, Dell Technologies, Inc. All Rights Reserved.
 *
 * Licensed under the Apache License, Version 2.0 (the "License").
 * You may not use this file except in compliance with the License.

diff --git a/ECSUtil/ECSGlobal.h b/ECSUtil/ECSGlobal.h
@@ -1,5 +1,5 @@
 /*
-* Copyright (c) 2017 - 2020, Dell Technologies, Inc. All Rights Reserved.
+* Copyright (c) 2017 - 2021, Dell Technologies, Inc. All Rights Reserved.
 *
 * Licensed under the Apache License, Version 2.0 (the "License").
 * You may not use this file except in compliance with the License.

diff --git a/ECSUtil/ECSUtil.cpp b/ECSUtil/ECSUtil.cpp
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2017 - 2020, Dell Technologies, Inc. All Rights Reserved.
+ * Copyright (c) 2017 - 2021, Dell Technologies, Inc. All Rights Reserved.
  *
  * Licensed under the Apache License, Version 2.0 (the "License").
  * You may not use this file except in compliance with the License.

diff --git a/ECSUtil/ECSUtil.h b/ECSUtil/ECSUtil.h
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2017 - 2020, Dell Technologies, Inc. All Rights Reserved.
+ * Copyright (c) 2017 - 2021, Dell Technologies, Inc. All Rights Reserved.
  *
  * Licensed under the Apache License, Version 2.0 (the "License").
  * You may not use this file except in compliance with the License.

diff --git a/ECSUtil/ECSUtil.vcxproj b/ECSUtil/ECSUtil.vcxproj
@@ -271,6 +271,7 @@
       <PreprocessToFile>false</PreprocessToFile>
       <PreprocessKeepComments>false</PreprocessKeepComments>
       <DebugInformationFormat>ProgramDatabase</DebugInformationFormat>
+      <LanguageStandard>stdcpplatest</LanguageStandard>
     </ClCompile>
     <Link>
       <SubSystem>Windows</SubSystem>
@@ -303,6 +304,7 @@
       <PreprocessToFile>false</PreprocessToFile>
       <PreprocessKeepComments>false</PreprocessKeepComments>
       <DebugInformationFormat>OldStyle</DebugInformationFormat>
+      <LanguageStandard>stdcpplatest</LanguageStandard>
     </ClCompile>
     <Link>
       <SubSystem>Windows</SubSystem>
@@ -331,6 +333,7 @@
       <PreprocessToFile>false</PreprocessToFile>
       <PreprocessKeepComments>false</PreprocessKeepComments>
       <DebugInformationFormat>OldStyle</DebugInformationFormat>
+      <LanguageStandard>stdcpplatest</LanguageStandard>
     </ClCompile>
     <Link>
       <SubSystem>Windows</SubSystem>
@@ -360,6 +363,7 @@
       <PreprocessKeepComments>false</PreprocessKeepComments>
       <DebugInformationFormat>ProgramDatabase</DebugInformationFormat>
       <OmitFramePointers>false</OmitFramePointers>
+      <LanguageStandard>stdcpplatest</LanguageStandard>
     </ClCompile>
     <Link>
       <SubSystem>Windows</SubSystem>
@@ -393,6 +397,7 @@
       <PreprocessKeepComments>false</PreprocessKeepComments>
       <DebugInformationFormat>OldStyle</DebugInformationFormat>
       <OmitFramePointers>false</OmitFramePointers>
+      <LanguageStandard>stdcpplatest</LanguageStandard>
     </ClCompile>
     <Link>
       <SubSystem>Windows</SubSystem>
@@ -419,6 +424,7 @@
       <PreprocessKeepComments>false</PreprocessKeepComments>
       <DebugInformationFormat>OldStyle</DebugInformationFormat>
       <OmitFramePointers>false</OmitFramePointers>
+      <LanguageStandard>stdcpplatest</LanguageStandard>
     </ClCompile>
     <Link>
       <SubSystem>Windows</SubSystem>
@@ -448,6 +454,7 @@
       <InlineFunctionExpansion>AnySuitable</InlineFunctionExpansion>
       <FavorSizeOrSpeed>Speed</FavorSizeOrSpeed>
       <OmitFramePointers>true</OmitFramePointers>
+      <LanguageStandard>stdcpplatest</LanguageStandard>
     </ClCompile>
     <Link>
       <SubSystem>Windows</SubSystem>
@@ -487,6 +494,7 @@
       <InlineFunctionExpansion>AnySuitable</InlineFunctionExpansion>
       <FavorSizeOrSpeed>Speed</FavorSizeOrSpeed>
       <OmitFramePointers>true</OmitFramePointers>
+      <LanguageStandard>stdcpplatest</LanguageStandard>
     </ClCompile>
     <Link>
       <SubSystem>Windows</SubSystem>
@@ -522,6 +530,7 @@
       <InlineFunctionExpansion>AnySuitable</InlineFunctionExpansion>
       <FavorSizeOrSpeed>Speed</FavorSizeOrSpeed>
       <OmitFramePointers>true</OmitFramePointers>
+      <LanguageStandard>stdcpplatest</LanguageStandard>
     </ClCompile>
     <Link>
       <SubSystem>Windows</SubSystem>
@@ -556,6 +565,7 @@
       <InlineFunctionExpansion>AnySuitable</InlineFunctionExpansion>
       <FavorSizeOrSpeed>Speed</FavorSizeOrSpeed>
       <OmitFramePointers>true</OmitFramePointers>
+      <LanguageStandard>stdcpplatest</LanguageStandard>
     </ClCompile>
     <Link>
       <SubSystem>Windows</SubSystem>
@@ -595,6 +605,7 @@
       <InlineFunctionExpansion>AnySuitable</InlineFunctionExpansion>
       <FavorSizeOrSpeed>Speed</FavorSizeOrSpeed>
       <OmitFramePointers>true</OmitFramePointers>
+      <LanguageStandard>stdcpplatest</LanguageStandard>
     </ClCompile>
     <Link>
       <SubSystem>Windows</SubSystem>
@@ -627,6 +638,7 @@
       <InlineFunctionExpansion>AnySuitable</InlineFunctionExpansion>
       <FavorSizeOrSpeed>Speed</FavorSizeOrSpeed>
       <OmitFramePointers>true</OmitFramePointers>
+      <LanguageStandard>stdcpplatest</LanguageStandard>
     </ClCompile>
     <Link>
       <SubSystem>Windows</SubSystem>

diff --git a/ECSUtil/FileSupport.cpp b/ECSUtil/FileSupport.cpp
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2017 - 2020, Dell Technologies, Inc. All Rights Reserved.
+ * Copyright (c) 2017 - 2021, Dell Technologies, Inc. All Rights Reserved.
  *
  * Licensed under the Apache License, Version 2.0 (the "License").
  * You may not use this file except in compliance with the License.

diff --git a/ECSUtil/FileSupport.h b/ECSUtil/FileSupport.h
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2017 - 2020, Dell Technologies, Inc. All Rights Reserved.
+ * Copyright (c) 2017 - 2021, Dell Technologies, Inc. All Rights Reserved.
  *
  * Licensed under the Apache License, Version 2.0 (the "License").
  * You may not use this file except in compliance with the License.

diff --git a/ECSUtil/GetAllThreads.cpp b/ECSUtil/GetAllThreads.cpp
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2017 - 2020, Dell Technologies, Inc. All Rights Reserved.
+ * Copyright (c) 2017 - 2021, Dell Technologies, Inc. All Rights Reserved.
  *
  * Licensed under the Apache License, Version 2.0 (the "License").
  * You may not use this file except in compliance with the License.

diff --git a/ECSUtil/GetAllThreads.h b/ECSUtil/GetAllThreads.h
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2017 - 2020, Dell Technologies, Inc. All Rights Reserved.
+ * Copyright (c) 2017 - 2021, Dell Technologies, Inc. All Rights Reserved.
  *
  * Licensed under the Apache License, Version 2.0 (the "License").
  * You may not use this file except in compliance with the License.

diff --git a/ECSUtil/Logging.cpp b/ECSUtil/Logging.cpp
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2017 - 2020, Dell Technologies, Inc. All Rights Reserved.
+ * Copyright (c) 2017 - 2021, Dell Technologies, Inc. All Rights Reserved.
  *
  * Licensed under the Apache License, Version 2.0 (the "License").
  * You may not use this file except in compliance with the License.
@@ -39,7 +39,7 @@ void LogMessageVa(LPCTSTR pszFile, DWORD dwLine, LPCTSTR pszLogMessage, NTSTATUS
 	sMsg.FormatMessageV(pszLogMessage, &marker);
 	if (pLogMessageCB == nullptr)
 	{
-		OutputDebugString(sMsg + ((dwError == ERROR_SUCCESS) ? _T("") : _T(" - ") + GetNTErrorText(dwError)));
+		OutputDebugString(sMsg + ((dwError == ERROR_SUCCESS) ? _T("") : (LPCTSTR)(_T(" - ") + GetNTErrorText(dwError))));
 	}
 	else
 	{

diff --git a/ECSUtil/Logging.h b/ECSUtil/Logging.h
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2017 - 2020, Dell Technologies, Inc. All Rights Reserved.
+ * Copyright (c) 2017 - 2021, Dell Technologies, Inc. All Rights Reserved.
  *
  * Licensed under the Apache License, Version 2.0 (the "License").
  * You may not use this file except in compliance with the License.

diff --git a/ECSUtil/NTERRTXT.CPP b/ECSUtil/NTERRTXT.CPP
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2017 - 2020, Dell Technologies, Inc. All Rights Reserved.
+ * Copyright (c) 2017 - 2021, Dell Technologies, Inc. All Rights Reserved.
  *
  * Licensed under the Apache License, Version 2.0 (the "License").
  * You may not use this file except in compliance with the License.

diff --git a/ECSUtil/NTERRTXT.H b/ECSUtil/NTERRTXT.H
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2017 - 2020, Dell Technologies, Inc. All Rights Reserved.
+ * Copyright (c) 2017 - 2021, Dell Technologies, Inc. All Rights Reserved.
  *
  * Licensed under the Apache License, Version 2.0 (the "License").
  * You may not use this file except in compliance with the License.

diff --git a/ECSUtil/ProcessEvent.cpp b/ECSUtil/ProcessEvent.cpp
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2017 - 2020, Dell Technologies, Inc. All Rights Reserved.
+ * Copyright (c) 2017 - 2021, Dell Technologies, Inc. All Rights Reserved.
  *
  * Licensed under the Apache License, Version 2.0 (the "License").
  * You may not use this file except in compliance with the License.

diff --git a/ECSUtil/ProcessEvent.h b/ECSUtil/ProcessEvent.h
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2017 - 2020, Dell Technologies, Inc. All Rights Reserved.
+ * Copyright (c) 2017 - 2021, Dell Technologies, Inc. All Rights Reserved.
  *
  * Licensed under the Apache License, Version 2.0 (the "License").
  * You may not use this file except in compliance with the License.

diff --git a/ECSUtil/S3Error.cpp b/ECSUtil/S3Error.cpp
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2017 - 2020, Dell Technologies, Inc. All Rights Reserved.
+ * Copyright (c) 2017 - 2021, Dell Technologies, Inc. All Rights Reserved.
  *
  * Licensed under the Apache License, Version 2.0 (the "License").
  * You may not use this file except in compliance with the License.

diff --git a/ECSUtil/S3Error.h b/ECSUtil/S3Error.h
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2017 - 2020, Dell Technologies, Inc. All Rights Reserved.
+ * Copyright (c) 2017 - 2021, Dell Technologies, Inc. All Rights Reserved.
  *
  * Licensed under the Apache License, Version 2.0 (the "License").
  * You may not use this file except in compliance with the License.

diff --git a/ECSUtil/SimpleWorkerThread.cpp b/ECSUtil/SimpleWorkerThread.cpp
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2017 - 2020, Dell Technologies, Inc. All Rights Reserved.
+ * Copyright (c) 2017 - 2021, Dell Technologies, Inc. All Rights Reserved.
  *
  * Licensed under the Apache License, Version 2.0 (the "License").
  * You may not use this file except in compliance with the License.
@@ -131,7 +131,7 @@ bool CSimpleWorkerThread::CreateThread(
 			(void)pThread->ResumeThread();
 			// wait for it to die.
 			(void)WaitForSingleObject(pThread->m_hThread, SECONDS(1));
-			return nullptr;
+			return false;
 		}
 		// if win10 or later, set thread description
 		if (bGotThreadDescription)

diff --git a/ECSUtil/SimpleWorkerThread.h b/ECSUtil/SimpleWorkerThread.h
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2017 - 2020, Dell Technologies, Inc. All Rights Reserved.
+ * Copyright (c) 2017 - 2021, Dell Technologies, Inc. All Rights Reserved.
  *
  * Licensed under the Apache License, Version 2.0 (the "License").
  * You may not use this file except in compliance with the License.

diff --git a/ECSUtil/ThreadPool.cpp b/ECSUtil/ThreadPool.cpp
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2017 - 2020, Dell Technologies, Inc. All Rights Reserved.
+ * Copyright (c) 2017 - 2021, Dell Technologies, Inc. All Rights Reserved.
  *
  * Licensed under the Apache License, Version 2.0 (the "License").
  * You may not use this file except in compliance with the License.