This repository has been archived by the owner on Aug 30, 2022. It is now read-only.
Feature/better handle k1 public key format on signing #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the fix for Enhance sanity check for keys returned from getRequiredKey.
The solution is quite different with initial thought. Instead of remove or change the sanity check of eosio-java. It could be done by signature provider side by: replacing legacy key setting by return both format of SECP256K1 public key (EOS and PUB_K1_) on getAvailableKe(). the Sanity check of eosio-java now could validate the subset from get_required_keys correctly.