#427 - Validation of datavalidations throw an exception when Formula1…

… is empty even if AllowBlank was set to true
EPPlusSoftware · Jul 6, 2021 · 85c1fb7 · 85c1fb7
1 parent 3e342b6
commit 85c1fb7
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/src/EPPlus/DataValidation/ExcelDataValidation.cs b/src/EPPlus/DataValidation/ExcelDataValidation.cs
@@ -253,7 +253,7 @@ public virtual void Validate()
         {
             var address = Address.Address;
             // validate Formula1
-            if (string.IsNullOrEmpty(Formula1Internal))
+            if (string.IsNullOrEmpty(Formula1Internal) && !(AllowBlank ?? false))
             {
                 throw new InvalidOperationException("Validation of " + address + " failed: Formula1 cannot be empty");
             }

diff --git a/src/EPPlusTest/DataValidation/DataValidationTests.cs b/src/EPPlusTest/DataValidation/DataValidationTests.cs
@@ -154,6 +154,21 @@ public void DataValidations_ShouldAcceptOneItemOnly()
             validation.Validate();
         }
 
+        [TestMethod]
+        public void DataValidations_ShouldNotThrowIfAllowBlankIsSet()
+        {
+            var validation = _sheet.DataValidations.AddListValidation("A1");
+            validation.AllowBlank = true;
+            validation.Validate();
+        }
+
+        [TestMethod, ExpectedException(typeof(InvalidOperationException))]
+        public void DataValidations_ShouldThrowIfAllowBlankIsNotSet()
+        {
+            var validation = _sheet.DataValidations.AddListValidation("A1");
+            validation.Validate();
+        }
+
         [TestMethod]
         public void ExcelDataValidation_ShouldReplaceLastPartInWholeColumnRangeWithMaxNumberOfRowsOneColumn()
         {