Correctly Report Invalid Row Names #1799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, HiGHS may silently not write an MPS file when it runs into invalid row names and still return kOK.
|
Thanks for spotting this. I'll look at this soon and consider your suggestion |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, HiGHS may silently not write an MPS file when it runs into invalid row names and still return kOK.
I ran into this with a model that has long names with spaces in it.
Presumably a silly typo or copy&paste error.
This is the minimal fix, but some log message indicating what went wrong may also be nice.
Maybe it would be even better to just include this in the
construct_namescase innormaliseNames. That way, the MPS would still be written with constructed names, a warning message would be printed and kWarning would be returned.What do you think?