Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cam6_4_030: fix psl values sent to coupler in cam7 #1128

Merged
merged 4 commits into from
Sep 6, 2024
Merged

cam6_4_030: fix psl values sent to coupler in cam7 #1128

merged 4 commits into from
Sep 6, 2024

Conversation

brian-eaton
Copy link
Collaborator

Fix issue #1116 - Test SMS_Ld2.ne30pg3_t232.BMT1850.derecho_gnu.allactive-defaultio Fails

  • The cam7 version of tphysbc has a call to cpslec added in front of the call to cam_export so that psl is set consistent with the state sent to the coupler.
  • This fix does not change answers for F compsets using cam7. It will affect answers in B compsets using cam7.

Fix issue #805 - cplsec.F90 needs to be in a module.

  • Add subroutine cpslec to a new module, src/utils/cam_diagnostic_utils.F90

fixes #1116
fixes #805

@brian-eaton brian-eaton added BFB bit for bit tag bug-fix This PR was created to fix a specific bug. labels Aug 16, 2024
@brian-eaton brian-eaton self-assigned this Aug 16, 2024
@peverwhee peverwhee self-requested a review September 4, 2024 16:34
@cacraigucar cacraigucar removed the request for review from peverwhee September 4, 2024 16:34
@peverwhee peverwhee self-requested a review September 4, 2024 16:35
@cacraigucar cacraigucar requested review from cacraigucar and removed request for peverwhee September 4, 2024 16:36
@cacraigucar cacraigucar assigned cacraigucar and unassigned peverwhee Sep 4, 2024
@cacraigucar cacraigucar changed the title fix psl values sent to coupler in cam7 cam6_4_030: fix psl values sent to coupler in cam7 Sep 6, 2024
@cacraigucar cacraigucar merged commit 06d91f7 into ESCOMP:cam_development Sep 6, 2024
2 checks passed
gold2718 pushed a commit to gold2718/CAM that referenced this pull request Oct 16, 2024
@cacraigucar
ESCOMP tag: cam6_4_030
c509b4a 
Merge pull request ESCOMP#1128 from brian-eaton/psl

cam6_4_030: fix psl values sent to coupler in cam7

ESCOMP commit: 06d91f7
gold2718 pushed a commit to gold2718/CAM that referenced this pull request Oct 16, 2024
@cacraigucar
ESCOMP tag: cam6_4_030
bc4ee84 
Merge pull request ESCOMP#1128 from brian-eaton/psl

cam6_4_030: fix psl values sent to coupler in cam7

ESCOMP commit: 06d91f7
gold2718 pushed a commit to gold2718/CAM that referenced this pull request Nov 8, 2024
@cacraigucar
ESCOMP tag: cam6_4_030
aac3a11 
Merge pull request ESCOMP#1128 from brian-eaton/psl

cam6_4_030: fix psl values sent to coupler in cam7

ESCOMP commit: 06d91f7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cacraigucar cacraigucar cacraigucar approved these changes

Assignees

@brian-eaton brian-eaton

@cacraigucar cacraigucar

Labels
BFB bit for bit tag bug-fix This PR was created to fix a specific bug.
Projects
CAM Development
Status: Tag
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brian-eaton @cacraigucar @peverwhee