cam6_4_026: Neglected to remove the 0.5*timestep call from zm_convr_run - done now #1137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Repartition dust deposition fluxes passed to surface models
nusbaume
approved these changes
Aug 29, 2024
There was a problem hiding this comment.
Well it was a pretty brutal review, but I just made it through. Thanks @cacraigucar!
cacraigucar
changed the title
gold2718
pushed a commit
to gold2718/CAM
that referenced
this pull request
Oct 16, 2024
Merge pull request ESCOMP#1137 from cacraigucar/zm_cleanup3a cam6_4_026: Neglected to remove the 0.5*timestep call from zm_convr_run - done now ESCOMP commit: 7decb60
gold2718
pushed a commit
to gold2718/CAM
that referenced
this pull request
Oct 16, 2024
Merge pull request ESCOMP#1137 from cacraigucar/zm_cleanup3a cam6_4_026: Neglected to remove the 0.5*timestep call from zm_convr_run - done now ESCOMP commit: 7decb60
gold2718
pushed a commit
to gold2718/CAM
that referenced
this pull request
Nov 8, 2024
Merge pull request ESCOMP#1137 from cacraigucar/zm_cleanup3a cam6_4_026: Neglected to remove the 0.5*timestep call from zm_convr_run - done now ESCOMP commit: 7decb60
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actually removes the 0.5 from the call to zm_convr_run
closes #1124 with all the last change which should have been in there