Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

external gridded forcing capability for SCAM #628

Open
wants to merge 9 commits into
base: cam_development
Choose a base branch
from

Conversation

JulioTBacmeister
Copy link
Collaborator

This supersedes PR #595
Closes #594

This capability currently requires pre-computed gridded fields on FV latlon 1 degree grid

Have run a number of cases using this capability - can provide user_nl_cam as well path to gridded ERA reanalysis.

Have also run with this capability is off and standard SCAM IOPs. Answers look fine but have not done rigorous testing.

Copy link
Collaborator

@cacraigucar cacraigucar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass review

bld/namelist_files/namelist_definition.xml Outdated Show resolved Hide resolved
Comment on lines +1 to +2
!scmlon=$PTS_LON
!scmlat=$PTS_LAT
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete commented out lines here and below

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

!scmlat=$PTS_LAT
iopfile="$CASEROOT/STUB_iop.nc"
!ncdata="/home/aherring/scam/inic/SCAM_IC_288x192_L58_48_BL10.nc"
ncdata = '/glade/work/aherring/grids/vertical-res/L58/SCAM_IC_288x192_L58_48_BL10.nc'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All files need to be put into the svn repo and referenced without full pathnames

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JulioTBacmeister will email the list of files to put into the svn inputdata repo

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The files to use are one month of ERAI data from /glade/p/cdg/amp/juliob/ERAI/f09_omega/L58/2010 and will put the month "04" files into the inputdata svn repo.

src/control/history_scam.F90 Outdated Show resolved Hide resolved
src/control/scamMod.F90 Outdated Show resolved Hide resolved
src/dynamics/eul/scmforecast.F90 Outdated Show resolved Hide resolved
src/dynamics/eul/scmforecast.F90 Outdated Show resolved Hide resolved
src/dynamics/eul/scmforecast.F90 Outdated Show resolved Hide resolved
src/dynamics/eul/scmforecast.F90 Outdated Show resolved Hide resolved
src/dynamics/eul/scmforecast.F90 Outdated Show resolved Hide resolved
character*(max_path_len), public :: scm_ana_frc_file_template
character*(max_path_len), public :: scm_ana_frc_path

logical, public :: scm_ana_x_plevels = .true.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Set to default as false

src/control/scamMod.F90 Outdated Show resolved Hide resolved
src/dynamics/eul/get_ana_dynfrc_4scam.F90 Show resolved Hide resolved
src/dynamics/eul/get_ana_dynfrc_4scam.F90 Outdated Show resolved Hide resolved
src/dynamics/eul/get_ana_dynfrc_4scam.F90 Outdated Show resolved Hide resolved
!scmlat=$PTS_LAT
iopfile="$CASEROOT/STUB_iop.nc"
!ncdata="/home/aherring/scam/inic/SCAM_IC_288x192_L58_48_BL10.nc"
ncdata = '/glade/work/aherring/grids/vertical-res/L58/SCAM_IC_288x192_L58_48_BL10.nc'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JulioTBacmeister will email the list of files to put into the svn inputdata repo

character*(max_path_len), public :: scm_ana_frc_file_template
character*(max_path_len), public :: scm_ana_frc_path

logical, public :: scm_ana_x_plevels = .true.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has been changed to false. Verify that all of the other fields do turn off their mods with false

src/control/scamMod.F90 Outdated Show resolved Hide resolved
src/dynamics/eul/get_ana_dynfrc_4scam.F90 Outdated Show resolved Hide resolved
src/dynamics/eul/get_ana_dynfrc_4scam.F90 Outdated Show resolved Hide resolved
@cacraigucar cacraigucar assigned jtruesdal and unassigned cacraigucar Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Open PR - Initial Review
Development

Successfully merging this pull request may close these issues.

3 participants