Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Move hillslope variables off surface dataset #2434

Draft
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

samsrabin
Copy link
Collaborator

@samsrabin samsrabin commented Mar 22, 2024

Work in progress! Do not review!

Subject to force pushes!

Description of changes

This PR moves the variables required for hillslope runs off the surface dataset and onto the new hillslope_file. This makes it so we don't have to maintain a hillslope-specific surface dataset for testing purposes. If/when running with hillslopes becomes the default, we can move these variables back onto the surface dataset.

Specific notes

Contributors other than yourself, if any: None

CTSM Issues Fixed (include github issue #): None

Are answers expected to change (and if so in what way)? No

Any User Interface Changes (namelist or namelist defaults changes)? No

Testing performed, if any:

  • Derecho hillslope tests are b4b-identical with ctsm5.1.dev174
  • Izumi hillslope tests are b4b-identical with ctsm5.2.027
  • Izumi aux_clm tests are b4b-identical with ctsm5.2.027
  • rimport file
  • Derecho hillslope tests are b4b-identical with ctsm5.2.027, aside from change of HillslopeC test from I1850 to I2000

Waiting until this is next in queue

  • Merge in latest master tag
  • Derecho and Izumi aux_clm tests are b4b-identical with latest master tag, aside from change of HillslopeC test from I1850 to I2000

@samsrabin samsrabin added the enhancement new capability or improved behavior of existing capability label Mar 22, 2024
@samsrabin samsrabin self-assigned this Mar 22, 2024
@samsrabin samsrabin added the blocked: dependency Wait to work on this until dependency is resolved label Mar 25, 2024
@samsrabin
Copy link
Collaborator Author

Blocked: Waiting on 5.2.

@samsrabin samsrabin removed the blocked: dependency Wait to work on this until dependency is resolved label May 2, 2024
@samsrabin
Copy link
Collaborator Author

5.2 is in, so this is no longer blocked.

@samsrabin samsrabin added simple easy for anyone to work on bfb bit-for-bit and removed simple bfb labels Aug 8, 2024
mvdebolskiy and others added 3 commits August 22, 2024 09:45
Bring b4b-dev branch to main CTSM development.

- PLUMBER2 for ctsm5.2 datasets
- Last bit of PPE changes for namelist and parameter file settings
- Update run_sys_tests on Derecho for compiler jobs to run using 16 tasks
- Bring in a fix for dust emissions for coupling with CAM

Update cs.status parsing script to make expected BASELINE fails more obvious

Fix some issues with finding IC files for certain lnd_tuning_modes: all for cam7,
   clm5_0_cam6.0, and clm6_0_cam6.0
@samsrabin samsrabin added this to the CESM3 Answer changing freeze milestone Sep 9, 2024
@samsrabin samsrabin added the next this should get some attention in the next week or two. Normally each Thursday SE meeting. label Sep 19, 2024
@samsrabin samsrabin changed the base branch from b4b-dev to master September 19, 2024 16:13
@samsrabin
Copy link
Collaborator Author

I have to change the 5x5_amazon hillslope tests from I1850 to I2000 because there's no default 2000 surface dataset for that resolution. I've thus retargeted this branch at master instead of b4b-dev.

@samsrabin samsrabin added code health improving internal code structure to make easier to maintain (sustainability) and removed bfb bit-for-bit labels Sep 19, 2024
@wwieder wwieder removed the next this should get some attention in the next week or two. Normally each Thursday SE meeting. label Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code health improving internal code structure to make easier to maintain (sustainability) enhancement new capability or improved behavior of existing capability PR status: needs testing simple easy for anyone to work on
Projects
Status: In progress - master/b4b-dev
Status: In Progress
Development

Successfully merging this pull request may close these issues.

4 participants