-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Move hillslope variables off surface dataset #2434
Draft
samsrabin
wants to merge
13
commits into
ESCOMP:master
Choose a base branch
from
samsrabin:hillslopes-off-fsurdat
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsrabin
added
the
enhancement
new capability or improved behavior of existing capability
label
Mar 22, 2024
6 tasks
samsrabin
added
the
blocked: dependency
Wait to work on this until dependency is resolved
label
Mar 25, 2024
Blocked: Waiting on 5.2. |
samsrabin
removed
the
blocked: dependency
Wait to work on this until dependency is resolved
label
May 2, 2024
5.2 is in, so this is no longer blocked. |
samsrabin
added
simple
easy for anyone to work on
bfb
bit-for-bit
and removed
simple bfb
labels
Aug 8, 2024
Bring b4b-dev branch to main CTSM development. - PLUMBER2 for ctsm5.2 datasets - Last bit of PPE changes for namelist and parameter file settings - Update run_sys_tests on Derecho for compiler jobs to run using 16 tasks - Bring in a fix for dust emissions for coupling with CAM Update cs.status parsing script to make expected BASELINE fails more obvious Fix some issues with finding IC files for certain lnd_tuning_modes: all for cam7, clm5_0_cam6.0, and clm6_0_cam6.0
Merge master 20240828
hs-uii: Merge in latest b4b-dev
Add a namelist warning when hillslope hydrology is used with initial interpolation.
samsrabin
force-pushed
the
hillslopes-off-fsurdat
branch
from
September 18, 2024 18:31
94bf3f3
to
b6dd9f9
Compare
samsrabin
added
the
next
this should get some attention in the next week or two. Normally each Thursday SE meeting.
label
Sep 19, 2024
I have to change the |
samsrabin
added
code health
improving internal code structure to make easier to maintain (sustainability)
and removed
bfb
bit-for-bit
labels
Sep 19, 2024
wwieder
removed
the
next
this should get some attention in the next week or two. Normally each Thursday SE meeting.
label
Sep 19, 2024
Avoids requiring new fsurdat.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
code health
improving internal code structure to make easier to maintain (sustainability)
enhancement
new capability or improved behavior of existing capability
PR status: needs testing
simple
easy for anyone to work on
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress! Do not review!
Subject to force pushes!
Description of changes
This PR moves the variables required for hillslope runs off the surface dataset and onto the new
hillslope_file
. This makes it so we don't have to maintain a hillslope-specific surface dataset for testing purposes. If/when running with hillslopes becomes the default, we can move these variables back onto the surface dataset.Specific notes
Contributors other than yourself, if any: None
CTSM Issues Fixed (include github issue #): None
Are answers expected to change (and if so in what way)? No
Any User Interface Changes (namelist or namelist defaults changes)? No
Testing performed, if any:
rimport
fileHillslopeC
test fromI1850
toI2000
Waiting until this is next in queue
HillslopeC
test fromI1850
toI2000