-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds a broadcast of the namelist value 'urbantvmapalgo' #2534
base: b4b-dev
Are you sure you want to change the base?
Adds a broadcast of the namelist value 'urbantvmapalgo' #2534
Conversation
… it in so it is consistent across all ranks when not using the default value ('nn').
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix @briandobbins !
@briandobbins I'm rebasing this to come in on b4b-dev, so it can come in quicker. |
Is this ready to merge? |
@briandobbins Would you mind rebasing this onto ctsm5.3.0 and force-pushing? Not a big deal, but makes it clearer exactly what files are being changed. I tested |
@briandobbins Rebase no longer needed; I'll start testing now. |
Argh, my apologies -- I've just been swamped with deadlines. Before you test, though, there's an additional change needed (to enable 'redist' as an option in the namelist_definition_ctsm.xml file for the urbantvmapalgo option). Happy to add this after tonight, so if you want to delay one more day, or do it yourself, that'd be fine. Thanks so much! |
Ah okay, I'll let you handle that. Once you push I'll kick off the testing. |
Adds a broadcast of the namelist value (urbantvmapalgo) after reading it in so it is consistent across all ranks when not using the default value ('nn').
Description of changes
Simple one-line change; a namelist value wasn't being shared with ranks other than the main one reading the namelist. This lead to hangs when trying a different algorithm.
Specific notes
Contributors other than yourself, if any:
CTSM Issues Fixed (include github issue #):
#2533
Are answers expected to change (and if so in what way)?
No
Any User Interface Changes (namelist or namelist defaults changes)?
No
Does this create a need to change or add documentation? Did you do so?
No
Testing performed, if any:
Limited testing, but it's a one-line logical change. If more is needed, let me know. I just did a simple test with and without the change, looking at the values on all ranks.