Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move from depricated shr_file to shr_log #2627

Merged
merged 4 commits into from
Oct 8, 2024

Conversation

jedwards4b
Copy link
Contributor

Description of changes

This updates from the depricated shr_file_setLogunit to shr_log_setlogunit

Specific notes

Contributors other than yourself, if any:

CTSM Issues Fixed (include github issue #):

Are answers expected to change (and if so in what way)?

Any User Interface Changes (namelist or namelist defaults changes)?

Does this create a need to change or add documentation? Did you do so?

Testing performed, if any:
(List what testing you did to show your changes worked as expected)
(This can be manual testing or running of the different test suites)
(Documentation on system testing is here: https://github.com/ESCOMP/ctsm/wiki/System-Testing-Guide)
(aux_clm on derecho for intel/gnu and izumi for intel/gnu/nag/nvhpc is the standard for tags on master)

NOTE: Be sure to check your coding style against the standard
(https://github.com/ESCOMP/ctsm/wiki/CTSM-coding-guidelines) and review
the list of common problems to watch out for
(https://github.com/ESCOMP/CTSM/wiki/List-of-common-problems).

@ekluzek
Copy link
Collaborator

ekluzek commented Jun 28, 2024

We'll bring this in on the b4b-dev branch.

@ekluzek ekluzek added code health improving internal code structure to make easier to maintain (sustainability) tag: simple bfb labels Jun 28, 2024
@samsrabin samsrabin added simple bfb bit-for-bit and removed simple bfb labels Aug 8, 2024
@samsrabin
Copy link
Collaborator

Relates to #2736.

@samsrabin samsrabin changed the base branch from master to b4b-dev September 17, 2024 17:36
@samsrabin samsrabin self-assigned this Sep 26, 2024
Copy link
Collaborator

@samsrabin samsrabin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for fixing the trailing whitespace too. Now I just need to test.

@samsrabin
Copy link
Collaborator

I did most of the aux_clm suite today with okay results. However, there's a lot of work happening right now on b4b-dev with the beta03 cleanup, so I'm going to wait for that to settle down. Probably will pick this back up late in the week.

@samsrabin samsrabin added good first issue simple; good for first-time contributors and removed simple labels Oct 3, 2024
@samsrabin samsrabin merged commit cbea138 into ESCOMP:b4b-dev Oct 8, 2024
2 checks passed
@samsrabin samsrabin mentioned this pull request Oct 10, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bfb bit-for-bit code health improving internal code structure to make easier to maintain (sustainability) good first issue simple; good for first-time contributors PR status: needs testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants