Fix and improve anomaly forcings for ISSP cases #2686
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of having to specify anomaly_forcing = 'Anomaly.Forcing.Precip', 'Anomaly.Forcing.Temperature', etc.
Branch ssp-fix: Fix more typos of "anomaly."
Branch ssp-fix: Add Anomaly.Forcing.cmip6.ssp126.
ssp-fix branch: Add Anomaly.Forcing.cmip6.245, 370, 585.
Branch ssp-fix: Merge tag 'cdeps1.0.34' into ssp-fix
Branch ssp-fix: "anomaly_forcing now automatically set based on compset (ISSP*)." Also updates testmods accordingly.
Branch ssp-fix: Now actually sets anomaly_forcing based on compset.
samsrabin
force-pushed
the
ssp-anomaly-fixes
branch
from
0a71fe6
to
728257b
Compare
Branch ssp-fix: Only set anomaly_forcing for DATM SSP compsets.
Branch ssp-fix: Provide hint in error message if namelist variable invalid due to surrounding quote marks.
Branch ssp-fix: Make datm buildnml more robust.
To match what's run in aux_clm.
Branch ssp-fix: Bugfix to future-proofing of datm buildnml.
samsrabin
added
the
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Fixes a bug, and also makes it much simpler to run land-only SSP cases. Depends on ESCOMP/CDEPS#292.
Specific notes
Contributors other than yourself, if any: @ekluzek
CTSM Issues Fixed (include github issue #):
Are answers expected to change (and if so in what way)? Yes, for cases that were being bitten by #2301 before.
Any User Interface Changes (namelist or namelist defaults changes)? Yes; see ESCOMP/CDEPS#292.
Does this create a need to change or add documentation? Did you do so? Yes; yes.
Testing performed, if any:
datm_rcp45_anom_forctest unaffected as of 4b96267.datm_ssp126_anom_forctest unaffected as of c4ec313.Remaining work
ssptest suite: Removedatm_ssp*_anom_forctestmods, replacing tests using those withdefaultRunning-with-anomaly-forcing.rstISSP126test with 10x15ISSP245test? Would presumably be quicker to get through queue.