Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the choice of pressure in CLMU building energy model (BEM) #2758

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Change the choice of pressure in CLMU building energy model (BEM) #2758

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9687d03
Change pressure in building energy model
cathyxinchangli Sep 11, 2024
bf4fd13
Merge branch 'ESCOMP:master' into dehumidification_ctrl_bugfix
cathyxinchangli Sep 12, 2024
9539d4d
Update UrbBuildTempOleson2015Mod.F90
cathyxinchangli Sep 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/biogeophys/SoilTemperatureMod.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -541,7 +541,7 @@ subroutine SoilTemperature(bounds, num_urbanl, filter_urbanl, num_urbanc, filter
if ( IsProgBuildTemp() )then
call BuildingTemperature(bounds, num_urbanl, filter_urbanl, num_nolakec, filter_nolakec, &
tk(bounds%begc:bounds%endc, :), urbanparams_inst, &
temperature_inst, energyflux_inst, urbantv_inst)
temperature_inst, energyflux_inst, urbantv_inst, atm2lnd_inst)
end if

do fc = 1,num_nolakec
Expand Down
14 changes: 9 additions & 5 deletions src/biogeophys/UrbBuildTempOleson2015Mod.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ module UrbBuildTempOleson2015Mod
use UrbanTimeVarType , only : urbantv_type
use EnergyFluxType , only : energyflux_type
use TemperatureType , only : temperature_type
use atm2lndType , only : atm2lnd_type
use LandunitType , only : lun
use ColumnType , only : col
!
Expand All @@ -42,7 +43,7 @@ module UrbBuildTempOleson2015Mod
! !INTERFACE:
subroutine BuildingTemperature (bounds, num_urbanl, filter_urbanl, num_nolakec, &
filter_nolakec, tk, urbanparams_inst, temperature_inst, &
energyflux_inst, urbantv_inst)
energyflux_inst, urbantv_inst, atm2lnd_inst)
!
! !DESCRIPTION:
! Solve for t_building, inner surface temperatures of roof, sunw, shdw, and floor temperature
Expand Down Expand Up @@ -202,7 +203,7 @@ subroutine BuildingTemperature (bounds, num_urbanl, filter_urbanl, num_nolakec,
! !USES:
use shr_kind_mod , only : r8 => shr_kind_r8
use clm_time_manager, only : get_step_size_real
use clm_varcon , only : rair, pstd, cpair, sb, hcv_roof, hcv_roof_enhanced, &
use clm_varcon , only : rair, cpair, sb, hcv_roof, hcv_roof_enhanced, &
hcv_floor, hcv_floor_enhanced, hcv_sunw, hcv_shdw, &
em_roof_int, em_floor_int, em_sunw_int, em_shdw_int, &
dz_floor, dens_floor, cp_floor, vent_ach
Expand All @@ -224,10 +225,11 @@ subroutine BuildingTemperature (bounds, num_urbanl, filter_urbanl, num_nolakec,
type(temperature_type), intent(inout) :: temperature_inst ! temperature variables
type(energyflux_type) , intent(inout) :: energyflux_inst ! energy flux variables
type(urbantv_type) , intent(in) :: urbantv_inst ! urban time varying variables
type(atm2lnd_type) , intent(in) :: atm2lnd_inst ! forcing variables from atmosphere
!
! !LOCAL VARIABLES:
integer, parameter :: neq = 5 ! number of equation/unknowns
integer :: fc,fl,c,l ! indices
integer :: fc,fl,c,l,g ! indices
real(r8) :: dtime ! land model time step (s)
real(r8) :: building_hwr(bounds%begl:bounds%endl) ! building height to building width ratio (-)
real(r8) :: t_roof_inner_bef(bounds%begl:bounds%endl) ! roof inside surface temperature at previous time step (K)
Expand Down Expand Up @@ -310,6 +312,7 @@ subroutine BuildingTemperature (bounds, num_urbanl, filter_urbanl, num_nolakec,
ctype => col%itype , & ! Input: [integer (:)] column type
zi => col%zi , & ! Input: [real(r8) (:,:)] interface level below a "z" level (m)
z => col%z , & ! Input: [real(r8) (:,:)] layer thickness (m)
forc_pbot => atm2lnd_inst%forc_pbot_not_downscaled_grc, & ! Input: [real(r8) (:)] atmospheric pressure (Pa)
olyson marked this conversation as resolved.
Show resolved Hide resolved

ht_roof => lun%ht_roof , & ! Input: [real(r8) (:)] height of urban roof (m)
canyon_hwr => lun%canyon_hwr , & ! Input: [real(r8) (:)] ratio of building height to street hwidth (-)
Expand Down Expand Up @@ -348,6 +351,7 @@ subroutine BuildingTemperature (bounds, num_urbanl, filter_urbanl, num_nolakec,
! 5. Calculate building height to building width ratio
do fl = 1,num_urbanl
l = filter_urbanl(fl)
g = lun%gridcell(l)
if (urbpoi(l)) then
t_roof_inner_bef(l) = t_roof_inner(l)
t_sunw_inner_bef(l) = t_sunw_inner(l)
Expand Down Expand Up @@ -376,8 +380,8 @@ subroutine BuildingTemperature (bounds, num_urbanl, filter_urbanl, num_nolakec,
cp_floori(l) = cp_floor
! Intermediate calculation for concrete floor (W m-2 K-1)
cv_floori(l) = (dz_floori(l) * cp_floori(l)) / dtime
! Density of dry air at standard pressure and t_building (kg m-3)
rho_dair(l) = pstd / (rair*t_building_bef(l))
! Density of dry air at surface pressure and t_building (kg m-3)
rho_dair(l) = forc_pbot(g) / (rair*t_building_bef(l))
olyson marked this conversation as resolved.
Show resolved Hide resolved
! Building height to building width ratio
building_hwr(l) = canyon_hwr(l)*(1._r8-wtlunit_roof(l))/wtlunit_roof(l)
end if
Expand Down
Loading