Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mesh_plotter improvements #2772

Merged
merged 11 commits into from
Sep 23, 2024
Merged

Conversation

samsrabin
Copy link
Collaborator

@samsrabin samsrabin commented Sep 18, 2024

Description of changes

  • Adds --dpi option (default 300)
  • Existing output file without --overwrite will now actually fail
  • More reasonable cell-center marker sizes, with an option to disable them

Specific notes

Contributors other than yourself, if any: None

CTSM Issues Fixed (include github issue #): None

Are answers expected to change (and if so in what way)? No

Any User Interface Changes (namelist or namelist defaults changes)? Yes:

  • Adds --dpi option (default 300)
  • Adds --no-center-coords option; useful for when the red X's are uselessly small or way too big

Does this create a need to change or add documentation? Did you do so? No

Testing performed, if any:

  • Options tested manually
  • New Python system/unit tests added
  • Python unit testing passes
  • Python system testing passes

@samsrabin samsrabin self-assigned this Sep 18, 2024
@samsrabin samsrabin added the next this should get some attention in the next week or two. Normally each Thursday SE meeting. label Sep 18, 2024
@samsrabin samsrabin changed the base branch from master to b4b-dev September 18, 2024 22:57
@wwieder wwieder removed the next this should get some attention in the next week or two. Normally each Thursday SE meeting. label Sep 19, 2024
@samsrabin samsrabin added the PR status: awaiting review Work on this PR is paused while waiting for review. label Sep 20, 2024
@samsrabin samsrabin added the testing additions or changes to tests label Sep 23, 2024
Copy link
Collaborator

@adrifoster adrifoster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me. Some nice pythonic additions and improvements to code robustness.

@samsrabin samsrabin merged commit 00b9f3a into ESCOMP:b4b-dev Sep 23, 2024
2 checks passed
@samsrabin samsrabin removed the PR status: awaiting review Work on this PR is paused while waiting for review. label Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bfb bit-for-bit testing additions or changes to tests
Projects
Status: Done (non release/external)
Development

Successfully merging this pull request may close these issues.

3 participants