-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mesh_plotter improvements #2772
Merged
samsrabin
merged 11 commits into
ESCOMP:b4b-dev
from
samsrabin:mesh-plotter-improvements
Sep 23, 2024
Merged
mesh_plotter improvements #2772
samsrabin
merged 11 commits into
ESCOMP:b4b-dev
from
samsrabin:mesh-plotter-improvements
Sep 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsrabin
added
the
next
this should get some attention in the next week or two. Normally each Thursday SE meeting.
label
Sep 18, 2024
wwieder
removed
the
next
this should get some attention in the next week or two. Normally each Thursday SE meeting.
label
Sep 19, 2024
samsrabin
force-pushed
the
mesh-plotter-improvements
branch
from
September 19, 2024 21:00
f72d842
to
a234ac4
Compare
samsrabin
added
the
PR status: awaiting review
Work on this PR is paused while waiting for review.
label
Sep 20, 2024
samsrabin
force-pushed
the
mesh-plotter-improvements
branch
from
September 23, 2024 16:14
fd1d709
to
e725759
Compare
adrifoster
approved these changes
Sep 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great to me. Some nice pythonic additions and improvements to code robustness.
samsrabin
removed
the
PR status: awaiting review
Work on this PR is paused while waiting for review.
label
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
--dpi
option (default 300)--overwrite
will now actually failSpecific notes
Contributors other than yourself, if any: None
CTSM Issues Fixed (include github issue #): None
Are answers expected to change (and if so in what way)? No
Any User Interface Changes (namelist or namelist defaults changes)? Yes:
--dpi
option (default 300)--no-center-coords
option; useful for when the red X's are uselessly small or way too bigDoes this create a need to change or add documentation? Did you do so? No
Testing performed, if any: