Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge tmp-241219 branch to master #2928

Merged
merged 47 commits into from
Jan 9, 2025
Merged

Conversation

slevis-lmwg
Copy link
Contributor

Description of changes

Includes three tmp-241219 tags:

  • tmp-241219.n01.ctsm5.3.016 Merge b4b-dev:
    nfix_method options Houlton (default), Bytnerowicz (option)
  • tmp-241219.n02.ctsm5.3.016 FATES hydro test update
  • tmp-241219.n03.ctsm5.3.016 Bug fix for izumi nag tests to pass (b4b unless using Bytnerowicz)

Specific notes

Contributors other than yourself, if any:
@glemieux

CTSM Issues Fixed (include github issue #):
Fixes #2924 Fix problem with izumi nag tests
Fixes #2878 Remove fates_allom_smode shell_command update in FatesColdHydro testmod
Fixes #2869 Update temperature cost function for symbiotic nfix in FUN

Are answers expected to change (and if so in what way)?
Yes, fates cases only, as documented in the ChangeLog

Any User Interface Changes (namelist or namelist defaults changes)?
nfix_method, as documented in the ChangeLog

wwieder and others added 30 commits March 18, 2024 06:26
This tag includes the fix to NGEET/fates#1254 and will allow the current
default fates parameter file to be used in fates hydro tests
…nd update ctsm60 file so that it is based on the previous one with the nfix fields just added to the end
Merge b4b-dev

Bring in latest b4b-dev branch to main CTSM development.

- Update git-fleximod
- Fix equation number in tech note
- Implement urbanl and urbanc coszen filters
- Make ALBGRD and ALBGRI active by default
- Some adjustments to control pylint for the RXCROPMATURITY python tests
- Run_sys_tests: Print test list in --verbose/--debug.
Update temperature cost function for symbiotic Nfix in FUN
iRpointer files for restart now have the simulation timestamp in the filename

Add the simulation timestamp to the rpointer files. Also update submodules with this change
in CMEPS and CDEPS as well as updated cime to handle it. See the notes below for an explaination
about this.

Add a "clm" level directory under usermods_dirs so that the component where user-mods reside
is declared and to make them function the same as test-mods.
iRpointer files for restart now have the simulation timestamp in the filename

Add the simulation timestamp to the rpointer files. Also update submodules with this change
in CMEPS and CDEPS as well as updated cime to handle it. See the notes below for an explaination
about this.

Add a "clm" level directory under usermods_dirs so that the component where user-mods reside
is declared and to make them function the same as test-mods.
@slevis-lmwg slevis-lmwg self-assigned this Jan 9, 2025
@slevis-lmwg slevis-lmwg added enhancement new capability or improved behavior of existing capability FATES API update Changes to the FATES version that also REQUIRE an API change in CTSM PR status: ready PR: this is ready to merge in, with all tests satisfactory and reviews complete priority: Immediate Highest priority, something that was unexpected science Enhancement to or bug impacting science non-bfb Changes answers (incl. adding tests) labels Jan 9, 2025
@slevis-lmwg slevis-lmwg requested a review from ekluzek January 9, 2025 20:08
@slevis-lmwg
Copy link
Contributor Author

@ekluzek I am now ready to merge this, pending your (or someone else's) review :-)

doc/ChangeLog Show resolved Hide resolved
Copy link
Collaborator

@ekluzek ekluzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Glad we figured all of this out and can move back to master now. It's good to have these documented now.

I ask for the change to the ChangeLog that we've been chatting about, but otherwise marking this as appoved so it can come in.

doc/ChangeLog Show resolved Hide resolved
@slevis-lmwg slevis-lmwg merged commit 203db12 into ESCOMP:master Jan 9, 2025
2 checks passed
@slevis-lmwg slevis-lmwg deleted the tmp-241219 branch January 9, 2025 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement new capability or improved behavior of existing capability FATES API update Changes to the FATES version that also REQUIRE an API change in CTSM non-bfb Changes answers (incl. adding tests) PR status: ready PR: this is ready to merge in, with all tests satisfactory and reviews complete priority: Immediate Highest priority, something that was unexpected science Enhancement to or bug impacting science
Projects
None yet
4 participants