Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to recipe_seaborn.yml and seaborn diagnostic #3808

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

aytacpacal
Copy link

Description

  • Closes #issue_number
  • Link to documentation:

Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

New or updated recipe/diagnostic


To help with the number of pull requests:

- Modified the seaborn_diag.py for jointplot
- Modified the recipe_seaborn.yml to plot the figures
- Added Pacal, Aytac to config-references.yml
@aytacpacal aytacpacal requested a review from schlunma November 7, 2024 13:28
@aytacpacal aytacpacal self-assigned this Nov 7, 2024
Copy link
Contributor

@schlunma schlunma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for implementing this 👍 I have a couple of comments on the code.

Also, I wonder if it makes sense to put this into the recipes/cloud directory as some kind of recipe_clouds_scatterplot? @axel-lauer, what do you think?

esmvaltool/diag_scripts/seaborn_diag.py Outdated Show resolved Hide resolved
esmvaltool/diag_scripts/seaborn_diag.py Outdated Show resolved Hide resolved
esmvaltool/diag_scripts/seaborn_diag.py Outdated Show resolved Hide resolved
@diegokam diegokam self-assigned this Jan 8, 2025
@diegokam
Copy link
Contributor

diegokam commented Jan 8, 2025

Hi all, all the remaining codacy issues have been addressed and I was able to run the recipe successfully

@diegokam diegokam requested a review from schlunma January 8, 2025 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants