Revert MPAS external to version without OpenACC #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to correctness issues that were introduced when changing to a CAM-compatible OpenACC MPAS version in cam-ew2.0.004, this commit reverts back to the version used in cam-ew2.0.003 and ESCOMP/CAM tag cam6_3_136.
|
"correctness issues" refers to what was discussed in an email thread (thanks to @dazlich). This thread showed a marked difference in precipitation outputs since cam2.0.004. |
|
@dazlich and @supreethms1809, I was hoping in the review you could make sure this doesn't break anything for your (respective) work. I didn't see anything when I was doing F2000dev and CHAOS2000dev tests with this change during #21. |
|
I’m having trouble compiling this - apparently it doesn’t compile mpas_string_utils.F.
I git cloned the v2.2 master, and edited the cam block in Externals.cfg to read:
[cam]
#tag = release-cam-ew2.2
branch = revert_mpas_noopenacc
protocol = git
#repo_url = https://github.com/EarthWorksOrg/CAM
repo_url = https://github.com/gdicker1/CAM
local_path = components/cam
externals = Externals_CAM.cfg
required = True
On Jul 15, 2024, at 11:46 AM, G. Dylan Dickerson ***@***.***> wrote:
** Caution: EXTERNAL Sender **
@dazlich<https://github.com/dazlich> and @supreethms1809<https://github.com/supreethms1809>, I was hoping in the review you could make sure this doesn't break anything for your (respective) work. I didn't see anything when I was doing F2000dev and CHAOS2000dev tests with this change during #21<#21>.
—
Reply to this email directly, view it on GitHub<#22 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ADS3XWADK42VRWRX25J2PC3ZMQDILAVCNFSM6AAAAABK47YKT6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMRZGA2TONRSGQ>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
Apologies I used the wrong (v8.1) hash. The fixup commit I pushed uses the hash I intended. I'll squash this once approved. I was able to build after switching the hash. |
|
Ok, it compiles and runs properly for me now. I'm good with it! |
gdicker1
added a commit
that referenced
this pull request
Jul 19, 2024
Fix correctness issues by reverting MPAS-A to a v7.3 version without OpenACC directives. NOTE: This will require cases using cam_dev physics to have 'use_gw_front = .false.' in user_nl_cam (if not already present).
|
This should have automatically closed with the push of ew-develop (to ed37226). Closing now since the change is merged |
gdicker1
pushed a commit
that referenced
this pull request
Aug 29, 2024
fix py3.11 issue in gitinterface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address correctness issues by reverting MPAS to a version without OpenACC. This is the same version that was used in tags cam-ew2.0.003 and before (and in cam6_3_136 and before).