Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added creply / cr #648

Merged
merged 31 commits into from
Nov 30, 2024
Merged

added creply / cr #648

merged 31 commits into from
Nov 30, 2024

Conversation

RealRTTV
Copy link
Contributor

No description provided.

@RealRTTV RealRTTV marked this pull request as ready for review June 23, 2024 16:38
@RealRTTV @xpple
Made changes in response to review
bb269be 
Co-authored-by: Frederik van der Els <[email protected]>
@RealRTTV
Copy link
Contributor Author

anything else?

@RealRTTV
Copy link
Contributor Author

anything else before merge?

xpple
xpple requested changes Jul 18, 2024
View reviewed changes
Copy link
Collaborator

@xpple xpple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes :).

src/main/java/net/earthcomputer/clientcommands/command/ReplyCommand.java Outdated Show resolved Hide resolved
RealRTTV
RealRTTV commented Jul 19, 2024
View reviewed changes
Copy link
Contributor Author

@RealRTTV RealRTTV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on phone so can't commit

src/main/java/net/earthcomputer/clientcommands/command/ReplyCommand.java Outdated Show resolved Hide resolved
src/main/java/net/earthcomputer/clientcommands/command/ReplyCommand.java Outdated Show resolved Hide resolved
src/main/resources/assets/clientcommands/lang/en_us.json Show resolved Hide resolved
src/main/java/net/earthcomputer/clientcommands/command/ReplyCommand.java Show resolved Hide resolved
src/main/java/net/earthcomputer/clientcommands/command/ReplyCommand.java Outdated Show resolved Hide resolved
RealRTTV
RealRTTV commented Jul 19, 2024
View reviewed changes
Copy link
Contributor Author

@RealRTTV RealRTTV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops

src/main/java/net/earthcomputer/clientcommands/command/ReplyCommand.java Outdated Show resolved Hide resolved
RealRTTV
RealRTTV commented Jul 19, 2024
View reviewed changes
Copy link
Contributor Author

@RealRTTV RealRTTV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bruh

src/main/java/net/earthcomputer/clientcommands/command/ReplyCommand.java Outdated Show resolved Hide resolved
src/main/java/net/earthcomputer/clientcommands/command/ReplyCommand.java Outdated Show resolved Hide resolved
@RealRTTV
Copy link
Contributor Author

RealRTTV commented Aug 9, 2024

lgtm

@RealRTTV RealRTTV requested a review from xpple September 27, 2024 00:59
@xpple xpple added the enhancement New feature or request label Sep 27, 2024
@RealRTTV RealRTTV requested a review from xpple September 28, 2024 14:35
@RealRTTV RealRTTV requested a review from xpple September 29, 2024 20:36
@RealRTTV
Copy link
Contributor Author

lfg

Earthcomputer
Earthcomputer requested changes Nov 27, 2024
View reviewed changes
Copy link
Owner

@Earthcomputer Earthcomputer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current implementation decides who to reply to based on when the chat GUI was opened rather than when the message was sent. This is not good design, please find a different way to make sure you don't accidentally reply to the wrong person

@RealRTTV
Copy link
Contributor Author

It can be changed to be whoever sent you a DM first, but in the case of someone sending you something while you're typing, that creates a big problem.

@Earthcomputer
Copy link
Owner

Why not just make it respond to whatever the last message was at the time you send the reply, minus a configurable delay, defaulting to, say, 0.5 seconds?

@RealRTTV
Copy link
Contributor Author

sure

@Earthcomputer Earthcomputer merged commit 22f4579 into Earthcomputer:fabric Nov 30, 2024
1 check passed
@RealRTTV
Copy link
Contributor Author

weeee

@RealRTTV RealRTTV deleted the creply branch November 30, 2024 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xpple xpple xpple approved these changes

@Earthcomputer Earthcomputer Earthcomputer approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RealRTTV @Earthcomputer @xpple