Fix empty query term conditions #6227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guillaume-sainthillier
force-pushed
the
fix-empty-queryTermConditions
branch
from
a553334
to
172498d
Compare
Merged
Seb33300
approved these changes
Apr 17, 2024
|
@javiereguiluz This PR is the correct fix for #6223 #6242 must be reverted (it breaks postgres) and replaced by this PR. See details in #6262 |
|
@guillaume-sainthillier could you commit revert of #6242 in this PR? |
guillaume-sainthillier
force-pushed
the
fix-empty-queryTermConditions
branch
from
172498d
to
206966a
Compare
done |
hellomedia
referenced
this pull request
Apr 20, 2024
This PR was merged into the 4.x branch. Discussion ---------- Fixed invalid DQL Fixes #6223 When searching text having only integer fields, an invalid DQL like `SELECT entity FROM App\Entity\Product entity WHERE ` is generated because there are no any `$queryTermConditions`. This PR should fix the issue. Commits ------- 6511215 Fixed invalid DQL
guillaume-sainthillier
force-pushed
the
fix-empty-queryTermConditions
branch
from
206966a
to
4ea1c86
Compare
Seb33300
approved these changes
Apr 29, 2024
|
Hello @Seb33300, any updates about this PR? Does I need to add something? |
|
Hi @guillaume-sainthillier, I just tried to help by reviewing it but I am not a maintainer of the project. |
guillaume-sainthillier
force-pushed
the
fix-empty-queryTermConditions
branch
from
4ea1c86
to
5d2e83d
Compare
|
Hello @javiereguiluz, any news about this PR? Does I need to add something to get this PR merged? phpstan error is not related to PR changes |
javiereguiluz
force-pushed
the
fix-empty-queryTermConditions
branch
from
5d2e83d
to
7537dbe
Compare
|
Thanks a lot, Guillaume! I'm sorry this PR fell off my radar and wasn't merged earlier. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When only numeric fields are searchable,
EntityRepository::addSearchClausegenerates a bugged DQL when search contains only non numeric terms.