[WIP] [RFC] Embedded crud in forms #6384
Conversation
psihius
force-pushed
the
embedded-crud
branch
4 times, most recently
from
fd78221
to
f379763
Compare
|
@psihius can you please share a screenshot of how i looks like when we embed a data table in a form? |
|
| /** @var array|null $embedContext */ | ||
| $embedContext = $context->getRequest()->query->all('embedContext'); | ||
| if (\array_key_exists('mappedBy', $embedContext)) { | ||
| $filterProperty = $embedContext['mappedBy']; | ||
| $filterValue = $embedContext['embeddedIn'] ?? null; | ||
| if (null !== $filterValue) { | ||
| // Use the parameter conversion capabilities of Doctrine | ||
| $metadata = $queryBuilder->getEntityManager()->getClassMetadata($context->getEntity()->getFqcn()); | ||
| $relatedEntityFqcn = $metadata->getAssociationTargetClass($filterProperty); | ||
| $relatedEntityMetadata = $queryBuilder->getEntityManager()->getClassMetadata($relatedEntityFqcn); | ||
| $type = $relatedEntityMetadata->getTypeOfField($metadata->getSingleIdentifierFieldName()); | ||
| if (Type::hasType($type)) { | ||
| $doctrineType = Type::getType($type); | ||
| $platform = $queryBuilder->getEntityManager()->getConnection()->getDatabasePlatform(); | ||
| $filterValue = $doctrineType->convertToDatabaseValue($filterValue, $platform); | ||
| } | ||
| $rootAlias = current($queryBuilder->getRootAliases()); | ||
| $associationMapping = $metadata->getAssociationMapping($filterProperty); | ||
| if (in_array($associationMapping['type'], [ClassMetadata::ONE_TO_MANY, ClassMetadata::MANY_TO_MANY], true)) { | ||
| $queryBuilder->andWhere(':filterValue MEMBER OF '.sprintf('%s.%s', $rootAlias, $filterProperty)) | ||
| ->setParameter('filterValue', $filterValue); | ||
| } else { | ||
| $queryBuilder->andWhere(sprintf('%s.%s', $rootAlias, $filterProperty) . ' = :filterValue') | ||
| ->setParameter('filterValue', $filterValue); | ||
| } | ||
| } | ||
| $field = $fields->getByProperty($filterProperty); | ||
| if ($field instanceof FieldDto) { | ||
| $fields->unset($field); | ||
| } | ||
| } |
There was a problem hiding this comment.
Can you move this into a separate method to keep the index action method simple to understand?
Not sur of what's the best between creating a new createEmbededIndexQueryBuilder() or something like filterEmbededQueryBuilder()
There was a problem hiding this comment.
Moving it is no problem, as I said - this is a rough draft that needs lots of work :)
As for the second point - maybe creating dedicated embedded(index|detail|edit|new|delete) actions or even rolling a EmbeddedAbstractController might be a better way of doing it, but then you have to maintain similar code. So the question is - what would be a better approach to refactor here so it is better long term? Those action methods already are pretty sizeable and adding to them might be a bit overkill :)
| .embed-spinner { | ||
| display: none; | ||
| top: 50%; | ||
| left: 50%; | ||
| margin-top: -1rem; | ||
| margin-left: -1rem; | ||
| z-index: 10; | ||
| } |
There was a problem hiding this comment.
You should be able to remove this by adding position-absolute top-50 start-50 translate-middle to your embed-spinner
See https://getbootstrap.com/docs/5.2/utilities/position/#center-elements
Note: this is a WIP and a Request For Comments aka feedback. This needs a lot more development, especially on making things work via AJAX and having a dedicated "embedded" layout, because right now it does not have as smooth functionality as it needs to. Also, a bunch of JS is commented out because I did not get to it yet. Filters are gonna be a major headache and probably would need improvements overall. This might turn into an epic of its own.
This is the ability to embed a whole data grid "index" page into a form via the
EmbedField::new('relation')This was based on #3543 PR, but a lot has changed since 3.x days and that PR needed a full re-work and bigger changes to the EA.
Lots to work on:
All feedback, patches and discussion are welcome. There's a wide field of discussion on how to approach this and implement it - I am thinking that we probably should have a dedicated
embedded_layoutform and have a dedicated template for the embedded grid rather than doing a single block render like it's doing now.