Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create LockedState component and add new lock icon #1533

Closed
wants to merge 2 commits into from

Conversation

btarver40
Copy link
Contributor

πŸ“ Changes

Please provide a brief summary of the changes made and why they were made.

Include any notes, screenshots, or videos that may be helpful for developers reviewing this pull request.

βœ… Checklist

Easy UI has certain UX standards that must be met. In general, non-trivial changes should meet the following criteria:

  • Visuals match Design Specs in Figma
  • Stories accompany any component changes
  • Code is in accordance with our style guide
  • Design tokens are utilized
  • Unit tests accompany any component changes
  • TSDoc is written for any API surface area
  • Specs are up-to-date
  • Console is free from warnings
  • No accessibility violations are reported
  • Cross-browser check is performed (Chrome, Safari, Firefox)
  • Changeset is added

Strikethrough any items that are not applicable to this pull request.

@btarver40 btarver40 marked this pull request as ready for review December 16, 2024 17:25
Copy link
Member

@stephenjwatkins stephenjwatkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after looking at this more, i actually think we should not add this component to easy ui for now. i thought we had more definition in figma for this component but i see now it's very sparse, and with only having a couple examples, and the component being so simple, i think the component should be left to the app to put together for now. nice work on this, though. sorry for the confusion.

we can add the lock icon though at least.

@btarver40
Copy link
Contributor Author

@stephenjwatkins ok sounds good I will update and just do the icon!

@btarver40 btarver40 closed this Dec 17, 2024
@stephenjwatkins stephenjwatkins deleted the T79396-create-locked-state-component branch January 8, 2025 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants