Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ForgeLayout): add modeswitcher, breadcrumb navigation, and … #1550

Merged
merged 10 commits into from
Dec 23, 2024

Conversation

OskiTheCoder
Copy link
Member

@OskiTheCoder OskiTheCoder commented Dec 19, 2024

📝 Changes

  • Adds control components for ForgeLayout
    [x] ForgeLayout.ModeSwitcher
    [x] ForgeLayout.BreadcrumbsNavigation
    [x] ForgeLayout.BackButton
    [x] ForgeLayout.Breadcrumbs
    [x] ForgeLayout.Breadcrumb

✅ Checklist

Easy UI has certain UX standards that must be met. In general, non-trivial changes should meet the following criteria:

  • Visuals match Design Specs in Figma
  • Stories accompany any component changes
  • Code is in accordance with our style guide
  • Design tokens are utilized
  • Unit tests accompany any component changes
  • TSDoc is written for any API surface area
  • Specs are up-to-date
  • Console is free from warnings
  • No accessibility violations are reported
  • Cross-browser check is performed (Chrome, Safari, Firefox)
  • Changeset is added

Strikethrough any items that are not applicable to this pull request.

@OskiTheCoder OskiTheCoder changed the title WIP: feat(ForgeLayout): add modeswitcher, breadcrumb navigation, and … feat(ForgeLayout): add modeswitcher, breadcrumb navigation, and … Dec 20, 2024
@OskiTheCoder OskiTheCoder marked this pull request as ready for review December 20, 2024 00:57
@OskiTheCoder OskiTheCoder marked this pull request as draft December 20, 2024 00:58
@OskiTheCoder OskiTheCoder marked this pull request as ready for review December 23, 2024 18:07
const { "aria-label": ariaLabel = "Search for content", ...textFieldProps } =
props;
return (
<div className={styles.searchContainer}>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the search bar and mode switcher have the same height in the mockup

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, unfortunately we don't have a TextField of that size, i checked with design and for now we're going to use a small size TextField

easy-ui-react/src/ForgeLayout/ForgeLayout.tsx Show resolved Hide resolved
@OskiTheCoder OskiTheCoder merged commit 462b0a4 into main Dec 23, 2024
5 checks passed
@OskiTheCoder OskiTheCoder deleted the forge_layout_add_controls branch December 23, 2024 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants