Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] Add function to retrieve API keys for a specific user #521

Merged
merged 3 commits into from
Sep 27, 2023
Merged

[feat] Add function to retrieve API keys for a specific user #521

merged 3 commits into from
Sep 27, 2023

Conversation

nwithan8
Copy link
Member

Description

  • Add function to retrieve API keys for a specific user

Testing

  • Add unit tests, cassettes

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)

dcaballeroc
dcaballeroc reviewed Sep 27, 2023
View reviewed changes
Copy link

@dcaballeroc dcaballeroc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have a small comment, but looks good overall

EasyPost/Services/ApiKeyService.cs Show resolved Hide resolved
@nwithan8 nwithan8 marked this pull request as ready for review September 27, 2023 18:57
@nwithan8 nwithan8 requested a review from a team September 27, 2023 18:57
jchen293
jchen293 approved these changes Sep 27, 2023
View reviewed changes
Copy link
Member

@jchen293 jchen293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, can you add a changelog entry?

jchen293
jchen293 previously requested changes Sep 27, 2023
View reviewed changes
EasyPost/Services/ApiKeyService.cs Outdated Show resolved Hide resolved
@nwithan8 nwithan8 merged commit b53c534 into master Sep 27, 2023
14 checks passed
@nwithan8 nwithan8 deleted the api_keys branch September 27, 2023 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcaballeroc dcaballeroc dcaballeroc approved these changes

@jchen293 jchen293 Awaiting requested review from jchen293

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nwithan8 @dcaballeroc @jchen293