Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] Remove beta carrier metadata #296

Merged
merged 2 commits into from
Dec 4, 2023
Merged

[chore] Remove beta carrier metadata #296

merged 2 commits into from
Dec 4, 2023

Conversation

nwithan8
Copy link
Member

@nwithan8 nwithan8 commented Dec 4, 2023

Description

  • Remove beta carrier metadata

Testing

  • Removed outdated unit tests + cassettes

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)

@nwithan8 nwithan8 requested a review from a team December 4, 2023 22:25
jchen293
jchen293 approved these changes Dec 4, 2023
View reviewed changes
Copy link
Member

@jchen293 jchen293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going to work on this tomorrow but ship it🚢

@nwithan8 nwithan8 merged commit 208efd2 into master Dec 4, 2023
17 checks passed
@nwithan8 nwithan8 deleted the carrier_metadata_beta branch December 4, 2023 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jchen293 jchen293 jchen293 approved these changes

@Justintime50 Justintime50 Justintime50 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nwithan8 @jchen293 @Justintime50