Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add allChildren and getNextPage functions #299

Merged
merged 8 commits into from
Jan 5, 2024
Merged

add allChildren and getNextPage functions #299

merged 8 commits into from
Jan 5, 2024

Conversation

jchen293
Copy link
Member

Description

  • Adds allChildren function in User service to get a paginated list of children
  • Adds getNextPage function in User service to get next paginated list of children

Testing

Add unit tests

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)

@jchen293 jchen293 marked this pull request as ready for review January 4, 2024 18:54
@jchen293 jchen293 requested a review from a team January 4, 2024 18:54
Justintime50
Justintime50 previously approved these changes Jan 4, 2024
View reviewed changes
src/main/java/com/easypost/model/Children.java Outdated Show resolved Hide resolved
src/main/java/com/easypost/service/UserService.java Outdated Show resolved Hide resolved
src/main/java/com/easypost/service/UserService.java Outdated Show resolved Hide resolved
nwithan8
nwithan8 previously approved these changes Jan 4, 2024
View reviewed changes
@jchen293 jchen293 dismissed stale reviews from nwithan8 and Justintime50 via c5a7aa1 January 4, 2024 20:18
nwithan8
nwithan8 previously approved these changes Jan 4, 2024
View reviewed changes
@jchen293 jchen293 requested a review from nwithan8 January 4, 2024 20:52
@jchen293 jchen293 merged commit c49459d into master Jan 5, 2024
17 checks passed
@jchen293 jchen293 deleted the all_children branch January 5, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nwithan8 nwithan8 nwithan8 approved these changes

@Justintime50 Justintime50 Awaiting requested review from Justintime50

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jchen293 @nwithan8 @Justintime50