[fix] Fire response hook before parsing API error to avoid early exit #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
- Remove dead code from unit test
jchen293
approved these changes
Jul 24, 2024
nwithan8
deleted the
321-feat-ability-to-extract-metrics-for-example-for-spring-based-apps-easily-by-making-sure-the-requestor-is-pluggable
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix an order-of-operations bug where API errors were being parsed (and potential exceptions thrown) before firing response hooks, meaning response hooks were not being triggered if an API call was unsuccessful.
Closes #321
Testing
Pull Request Type
Please select the option(s) that are relevant to this PR.