-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use DBArray for all LDB, LMT, and LMU structs #383
Draft
mateofio
wants to merge
47
commits into
EasyRPG:master
Choose a base branch
from
mateofio:array
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateofio
force-pushed
the
array
branch
3 times, most recently
from
August 19, 2020 08:02
6f36e38
to
8871856
Compare
Break header dependencies on dbarray.h
10 tasks
mateofio
changed the title
Optimize memory usage with DBArray
Use DBArray for all LDB, LMT, and LMU structs
Aug 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #379
This PR adds C++20 compatible
lcf::Span
and a newDBArray
array class, which has a similar storage policy and small memory footprint likeDBString
. It also adds aDBBitArray
bit vector replacement forvector<bool>
.This is a WIP, a lot of refactoring is needed in liblcf to get this new Array type working for all the chunks.
Here are some initial numbers where we just convert
EventCommand::parameters
to useDBArray