Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Links To Striver SDE Sheets #10811

Merged
merged 15 commits into from
Oct 30, 2023
Merged

Add Links To Striver SDE Sheets #10811

merged 15 commits into from
Oct 30, 2023

Conversation

jigs-bot
Copy link
Contributor

@jigs-bot jigs-bot commented Oct 26, 2023

check_urls=free-programming-books-cheatsheets.md

What does this PR do?

Added the link to strivers DSA Sheet

For resources

Description

Why is this valuable (or not)?

This sheet contain curated list of tech interview dsa questions .

How do we know it's really free?

For book lists, is it a book? For course lists, is it a course? etc.

Checklist:

  • Read our contributing guidelines.
  • Search for duplicates.
  • Include author(s) and platform where appropriate.
  • Put lists in alphabetical order, correct spacing.
  • Add needed indications (PDF, access notes, under construction).
  • Used an informative name for this pull request.

Follow-up

  • Check the status of GitHub Actions and resolve any reported warnings!

check_urls=free-programming-books-js.md
check_urls=free-programming-books-js.md
check_urls=free-programming-DSA-StriverSheet.md
@github-actions
Copy link

Linter failed, fix the error(s):

free-programming-books/more/free-programming-DSA-StriverSheet.md
5:1-5:118  warning  Incorrect number of blank lines between last section and next heading  blank-lines-1-0-2  remark-lint

@github-actions github-actions bot added the linter error Please, correct build errors found by linter! label Oct 26, 2023
check_urls=free-programming-DSA-StriverSheet.md
@github-actions github-actions bot removed the linter error Please, correct build errors found by linter! label Oct 26, 2023
Deleted a file with all broken links
@jigs-bot
Copy link
Contributor Author

@eshellman @sohansai @Ajay-singh1 Please Take a review and merge it ,Thankyou .

@jigs-bot
Copy link
Contributor Author

@eshellman Please Take a Review and Kindly Merge the PR .

@jigs-bot
Copy link
Contributor Author

jigs-bot commented Oct 26, 2023

@Thenlie @sohansai please take a look and kindly merge this PR .

Copy link
Member

@sohansai sohansai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The links to the books you provided are not from authorized sources. We strongly prefer links from authoritative sources, such as the author or publisher.

If you'd like to contribute English content books, please consider adding them to 'books/free-programming-books-en.md' instead of creating a new file. The same applies to programming cheat sheets; you can contribute them by adding them to 'more/free-programming-cheatsheets.md'.

Before contributing, please take a moment to read 'docs/CONTRIBUTING.md' for further guidance.

@sohansai
Copy link
Member

When reviewers have time, they'll review it. Please relax and avoid mentioning it repeatedly.

check_urls=free-programming-cheatsheets.md
@github-actions
Copy link

Linter failed, fix the error(s):

free-programming-books/more/free-programming-cheatsheets.md
125:1-132:107  warning  Alphabetical ordering: swap l.132 and l.131  alphabetize-lists  remark-lint

@github-actions github-actions bot added the linter error Please, correct build errors found by linter! label Oct 26, 2023
check_urls=free-programming-cheatsheets.md
@github-actions github-actions bot removed the linter error Please, correct build errors found by linter! label Oct 26, 2023
@jigs-bot jigs-bot changed the title Add Links To OpenCV Books Add Links To Striver SDE Sheets Oct 26, 2023
@jigs-bot
Copy link
Contributor Author

jigs-bot commented Oct 26, 2023

When reviewers have time, they'll review it. Please relax and avoid mentioning it repeatedly.

Sorry @sohansai , Removed the new file that i created and move the DSA Sheet link to the progrmmin-cheatsheet.md .

@github-actions
Copy link

Linter failed, fix the error(s):

free-programming-books/more/free-programming-cheatsheets.md
125:1-132:131  warning  Alphabetical ordering: swap l.131 and l.130  alphabetize-lists  remark-lint

@github-actions github-actions bot added the linter error Please, correct build errors found by linter! label Oct 27, 2023
@github-actions
Copy link

Linter failed, fix the error(s):

free-programming-books/more/free-programming-cheatsheets.md
125:1-132:131  warning  Alphabetical ordering: swap l.130 and l.129  alphabetize-lists  remark-lint

@Thenlie Thenlie added 🚀 ready to merge LGTM. Waiting for final approval changes made Submitter has responded to request for changes labels Oct 27, 2023
Copy link
Member

@Ajay-singh1 Ajay-singh1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Ready to merge.

@eshellman
Copy link
Collaborator

these aren't cheatsheets. they fit into the problem set category on the competetive programming list

@eshellman eshellman added waiting for changes PR has been reviewed and changes/suggestions requested and removed 🚀 ready to merge LGTM. Waiting for final approval changes made Submitter has responded to request for changes labels Oct 28, 2023
check_urls=problem-sets-competitive-programming.md
@github-actions
Copy link

Linter failed, fix the error(s):

free-programming-books/more/problem-sets-competitive-programming.md
13:1-53:37  warning  Alphabetical ordering: swap l.51 and l.50  alphabetize-lists  remark-lint

@github-actions github-actions bot added the linter error Please, correct build errors found by linter! label Oct 28, 2023
@github-actions github-actions bot removed the linter error Please, correct build errors found by linter! label Oct 28, 2023
@jigs-bot
Copy link
Contributor Author

jigs-bot commented Oct 28, 2023

@eshellman "CHANGES MADE" Successfully made the changes which you asked for , kindly review and merge .

@jigs-bot
Copy link
Contributor Author

jigs-bot commented Oct 28, 2023

@sohansai @Ajay-singh1 @Thenlie @SethFalco Kindly review ! Successfully made all the changes .

@Ajay-singh1
Copy link
Member

Wait for Eric!

@eshellman
Copy link
Collaborator

it seems your PR deletes a file (free-programming-interactive-tutorials-pt_BR.md)
did you mean to do that?

@eshellman eshellman added question Needs clarification by involved users / reviewers and removed waiting for changes PR has been reviewed and changes/suggestions requested labels Oct 29, 2023
@jigs-bot
Copy link
Contributor Author

jigs-bot commented Oct 29, 2023

it seems your PR deletes a file (free-programming-interactive-tutorials-pt_BR.md)
did you mean to do that?

Yes, The links in that file were broken or outdated..
After removing the broken links, there was nothing in the file so I removed.

@eshellman
Copy link
Collaborator

it seems your PR deletes a file (free-programming-interactive-tutorials-pt_BR.md)
did you mean to do that?

Yes, The links in that file were broken or outdated.. After removing the broken links, there was nothing in the file so I removed.

then you need to remove the link to it in README

@eshellman eshellman added waiting for changes PR has been reviewed and changes/suggestions requested help wanted Needs help solving a blocked / stucked item and removed question Needs clarification by involved users / reviewers help wanted Needs help solving a blocked / stucked item labels Oct 29, 2023
@jigs-bot
Copy link
Contributor Author

jigs-bot commented Oct 30, 2023

it seems your PR deletes a file (free-programming-interactive-tutorials-pt_BR.md)
did you mean to do that?

Yes, The links in that file were broken or outdated.. After removing the broken links, there was nothing in the file so I removed.

then you need to remove the link to it in README

@eshellman "Changes Made" Removed the link from readme .

@eshellman
Copy link
Collaborator

Thanks, and welcome to free-programming-books!

@eshellman eshellman merged commit f58ece1 into EbookFoundation:main Oct 30, 2023
6 checks passed
@jigs-bot
Copy link
Contributor Author

Thanks, and welcome to free-programming-books!

Thank you 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting for changes PR has been reviewed and changes/suggestions requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants