-
-
Notifications
You must be signed in to change notification settings - Fork 62.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Links To Striver SDE Sheets #10811
Conversation
check_urls=free-programming-books-js.md
check_urls=free-programming-books-js.md
check_urls=free-programming-DSA-StriverSheet.md
Linter failed, fix the error(s):
|
check_urls=free-programming-DSA-StriverSheet.md
Deleted a file with all broken links
@eshellman @sohansai @Ajay-singh1 Please Take a review and merge it ,Thankyou . |
@eshellman Please Take a Review and Kindly Merge the PR . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The links to the books you provided are not from authorized sources. We strongly prefer links from authoritative sources, such as the author or publisher.
If you'd like to contribute English content books, please consider adding them to 'books/free-programming-books-en.md' instead of creating a new file. The same applies to programming cheat sheets; you can contribute them by adding them to 'more/free-programming-cheatsheets.md'.
Before contributing, please take a moment to read 'docs/CONTRIBUTING.md' for further guidance.
When reviewers have time, they'll review it. Please relax and avoid mentioning it repeatedly. |
check_urls=free-programming-cheatsheets.md
Linter failed, fix the error(s):
|
check_urls=free-programming-cheatsheets.md
Sorry @sohansai , Removed the new file that i created and move the DSA Sheet link to the progrmmin-cheatsheet.md . |
Co-authored-by: Leithen <[email protected]>
Linter failed, fix the error(s):
|
check_urls=free-programming-cheatsheets.md
Linter failed, fix the error(s):
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Ready to merge.
these aren't cheatsheets. they fit into the problem set category on the competetive programming list |
check_urls=problem-sets-competitive-programming.md
Linter failed, fix the error(s):
|
@eshellman "CHANGES MADE" Successfully made the changes which you asked for , kindly review and merge . |
@sohansai @Ajay-singh1 @Thenlie @SethFalco Kindly review ! Successfully made all the changes . |
Wait for Eric! |
it seems your PR deletes a file (free-programming-interactive-tutorials-pt_BR.md) |
Yes, The links in that file were broken or outdated.. |
then you need to remove the link to it in README |
@eshellman "Changes Made" Removed the link from readme . |
Thanks, and welcome to free-programming-books! |
Thank you 🙏 |
check_urls=free-programming-books-cheatsheets.md
What does this PR do?
Added the link to strivers DSA Sheet
For resources
Description
Why is this valuable (or not)?
This sheet contain curated list of tech interview dsa questions .
How do we know it's really free?
For book lists, is it a book? For course lists, is it a course? etc.
Checklist:
Follow-up