Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update free-programming-books-de.md #10894

Closed
wants to merge 3 commits into from
Closed

Update free-programming-books-de.md #10894

wants to merge 3 commits into from

Conversation

pranav-94
Copy link
Contributor

What does this PR do?

Add resource(s) | Remove resource(s) | Add info | Improve repo

For resources

Description

Why is this valuable (or not)?

How do we know it's really free?

For book lists, is it a book? For course lists, is it a course? etc.

Checklist:

  • Read our contributing guidelines.
  • Search for duplicates.
  • Include author(s) and platform where appropriate.
  • Put lists in alphabetical order, correct spacing.
  • Add needed indications (PDF, access notes, under construction).
  • Used an informative name for this pull request.

Follow-up

  • Check the status of GitHub Actions and resolve any reported warnings!

@github-actions
Copy link

Linter failed, fix the error(s):

free-programming-books/books/free-programming-books-de.md
150:1-153:448  warning  Alphabetical ordering: swap l.153 and l.152  alphabetize-lists  remark-lint

@github-actions github-actions bot added the linter error Please, correct build errors found by linter! label Oct 30, 2023
@github-actions
Copy link

Linter failed, fix the error(s):

free-programming-books/books/free-programming-books-de.md
150:1-153:82  warning  Alphabetical ordering: swap l.153 and l.152  alphabetize-lists  remark-lint

@@ -150,6 +150,7 @@
* [JavaScript](http://www.peterkropff.de/site/javascript/javascript.htm) - Peter Kropff (Grundlagen, AJAX, DOM, OOP) (Online, PDF)
* [JavaScript und AJAX](http://openbook.rheinwerk-verlag.de/javascript_ajax) - Christian Wenz (Online)
* [Webseiten erstellen mit Javascript](http://www.highscore.de/javascript) - Boris Schäling (HTML)
* [Bible of JS](https://shorturl.at/ax056) - Sheryians Coding School (JavaScript)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't accept shortened links

Copy link
Contributor

@mohdahsanrazakhan mohdahsanrazakhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link shortener was not allowed.

@@ -150,6 +150,7 @@
* [JavaScript](http://www.peterkropff.de/site/javascript/javascript.htm) - Peter Kropff (Grundlagen, AJAX, DOM, OOP) (Online, PDF)
* [JavaScript und AJAX](http://openbook.rheinwerk-verlag.de/javascript_ajax) - Christian Wenz (Online)
* [Webseiten erstellen mit Javascript](http://www.highscore.de/javascript) - Boris Schäling (HTML)
* [Bible of JS](https://shorturl.at/ax056) - Sheryians Coding School (JavaScript)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* [Bible of JS](https://shorturl.at/ax056) - Sheryians Coding School (JavaScript)
* [Bible of JS](https://www.youtube.com/redirect?event=video_description&redir_token=QUFFLUhqbjVFU1JDVTlPS1hodnYzYWFORmpheExENjk4UXxBQ3Jtc0tuVERYNW84YUtUQ2oxUS1kX185NnBYb3g5Q0lzYUpzM2RCVVoxZUVydDRxeTBJOFptdjQ5NW16dUNiQlBWUmRRdWR6QjFfak90RVpuaE41TzBlQ21FRDFJLXVTMkE1MzJMbnMzS1VFRnNNOEdHQW1Odw&q=https%3A%2F%2Fsheryians.com%2Fdownload%2Fbibleofjs_by_sheryians&v=Aw_SmcpEOdY) - Harsh Sharma (PDF)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not redirects either!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah because author provide only this link, that's why this link directly download the book in pdf format

@eshellman eshellman added the waiting for changes PR has been reviewed and changes/suggestions requested label Oct 31, 2023
@pranav-94 pranav-94 closed this Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
linter error Please, correct build errors found by linter! waiting for changes PR has been reviewed and changes/suggestions requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants