MineDojo not supported by PPO and SAC-AE

Eclectic-Sheep · Aug 8, 2023 · 1a716ce · 1a716ce
1 parent 07f7f3b
commit 1a716ce
Show file tree

Hide file tree

Showing 3 changed files with 26 additions and 0 deletions.
diff --git a/sheeprl/algos/ppo/ppo.py b/sheeprl/algos/ppo/ppo.py
@@ -105,6 +105,15 @@ def train(
 def main():
     parser = HfArgumentParser(PPOArgs)
     args: PPOArgs = parser.parse_args_into_dataclasses()[0]
+
+    if "minedojo" in args.env_id:
+        raise ValueError(
+            "MineDojo is not currently supported by PPO agent, since it does not take "
+            "into consideration the action masks provided by the environment, but needed "
+            "in order to play correctly the game. "
+            "As an alternative you can use one of the Dreamers' agents."
+        )
+
     initial_ent_coef = copy.deepcopy(args.ent_coef)
     initial_clip_coef = copy.deepcopy(args.clip_coef)
 

diff --git a/sheeprl/algos/ppo/ppo_decoupled.py b/sheeprl/algos/ppo/ppo_decoupled.py
@@ -543,6 +543,14 @@ def main():
     parser = HfArgumentParser(PPOArgs)
     args: PPOArgs = parser.parse_args_into_dataclasses()[0]
 
+    if "minedojo" in args.env_id:
+        raise ValueError(
+            "MineDojo is not currently supported by PPO agent, since it does not take "
+            "into consideration the action masks provided by the environment, but needed "
+            "in order to play correctly the game. "
+            "As an alternative you can use one of the Dreamers' agents."
+        )
+
     if args.share_data:
         warnings.warn(
             "You have called the script with `--share_data=True`: "

diff --git a/sheeprl/algos/sac_ae/sac_ae.py b/sheeprl/algos/sac_ae/sac_ae.py
@@ -136,6 +136,15 @@ def train(
 def main():
     parser = HfArgumentParser(SACAEArgs)
     args: SACAEArgs = parser.parse_args_into_dataclasses()[0]
+
+    if "minedojo" in args.env_id:
+        raise ValueError(
+            "MineDojo is not currently supported by PPO agent, since it does not take "
+            "into consideration the action masks provided by the environment, but needed "
+            "in order to play correctly the game. "
+            "As an alternative you can use one of the Dreamers' agents."
+        )
+
     # These arguments cannot be changed
     args.screen_size = 64