Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dv3-imagination notebook #290

Merged
merged 5 commits into from
May 20, 2024
Merged

fix: dv3-imagination notebook #290

merged 5 commits into from
May 20, 2024

Conversation

michele-milesi
Copy link
Member

Summary

Describe the purpose of the pull request, including:

  • Fix dreamer v3 imagination notebook

Type of Change

Please select the one relevant option below:

  • Bug fix (non-breaking change that solves an issue)

Checklist

Please confirm that the following tasks have been completed:

  • I have tested my changes locally and they work as expected. (Please describe the tests you performed.)
  • I have added unit tests for my changes, or updated existing tests if necessary.
  • I have updated the documentation, if applicable.
  • I have installed pre-commit and run locally for my code changes.

Screenshots or Visuals (Optional)

I have tested on MsPacman, and the generated GIFs are reported below.

  • Imagination Steps:
    imagination

  • Real Observations collected during environment interaction:
    real_obs

Note:

The actions used during imagination are the same sampled during the environment interaction, i.e., imagine_actions = False in the notebook.

@michele-milesi michele-milesi linked an issue May 20, 2024 that may be closed by this pull request
@belerico belerico merged commit 28d14ba into main May 20, 2024
12 checks passed
@belerico belerico deleted the fix/dv3-imagination-notebook branch May 20, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dv3 Imagination notebook re-visited
2 participants