Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: policy steps update in on-policy algorithms #293

Merged
merged 1 commit into from
May 28, 2024
Merged

Conversation

michele-milesi
Copy link
Member

Summary

Describe the purpose of the pull request, including:

  • Fix the policy step update for on-policy algorithms: the rollout steps must not be included when updating the policy step (the update is inside the rollout for loop)

Type of Change

Please select the one relevant option below:

  • Bug fix (non-breaking change that solves an issue)

Checklist

Please confirm that the following tasks have been completed:

  • I have tested my changes locally and they work as expected. (Please describe the tests you performed.)
  • I have added unit tests for my changes, or updated existing tests if necessary.
  • I have updated the documentation, if applicable.
  • I have installed pre-commit and run locally for my code changes.

@DavideTr8 DavideTr8 merged commit 169d14a into main May 28, 2024
12 checks passed
Copy link
Member

@belerico belerico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if we modify the policy_steps_per_iter to NOT include the rollout-steps? In this case we are more coherent with the rest of the code-base?

@belerico belerico deleted the fix/policy_step branch June 18, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants