-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for iOS 17 #567
base: master
Are you sure you want to change the base?
Support for iOS 17 #567
Conversation
…log choice has been selected, and full calendar access is always requested in ios17
I can confirm these changes fixed the issue on my case (I manually replaced the content of the Calendar.h/.m files to test) |
Hello i tested and i confirm that callbacks are now ok. (full perm mode) But, i needed to add this code:
|
Well done @sjregan, this seems to be working. Though in our case I had to change plugin client logic to manual permission request, since it now no longer happens on initiation / function calls (cause now there is more than one kind of permission). |
Yes, I should have mentioned that and put in a note in the readme. |
For me giving the necessary permissions in config.xml and adding the permissions in deviceready solved the issue for me. |
I confirm it works with $CALENDARS_FULL_ACCESS_USAGE_DESCRIPTIONI don't added Write only acces because I don't need it. But it can be a good idea to add it to config.xml Any plan to update the plugin ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and working as expected on iOS 12 and iOS 17.
Hey @sjregan Thanks for the great work with this PR. |
17.1 is out, changed the condition to.. |
@danielprrazevedo no idea sorry, that function seemingly just returns a comparison to nil, so it shouldn’t trigger anything |
When will this be pushed to the master branch? Having to replace the code manually really sucks |
@jkenjarCR it’s disappointing when PRs don’t get merged, but you can point your package.json file to a specific commit |
How do you do this? |
https://duckduckgo.com/?t=h_&q=npm+install+package+specific+commit&ia=web |
I cant figure out the url :( |
The url: npm command: |
Hello is there any new version released ? |
Fixes permission requests in iOS 17.
Allows write only calendar access to be requested.