Only use whitelisted plugins for centralized swaps

EdgeApp · Feb 9, 2024 · 56a65ad · 56a65ad
1 parent a466162
commit 56a65ad
Show file tree

Hide file tree

Showing 8 changed files with 48 additions and 10 deletions.
diff --git a/src/swap/central/changehero.ts b/src/swap/central/changehero.ts
@@ -21,6 +21,7 @@ import {
 
 import {
   checkInvalidCodes,
+  checkWhitelistedMainnetCodes,
   CurrencyCodeTranscriptionMap,
   getCodesWithTranscription,
   getMaxSwappable,
@@ -194,15 +195,6 @@ export function makeChangeHeroPlugin(
       getAddress(request.toWallet)
     ])
 
-    // Supported chains must be whitelisted
-    if (
-      MAINNET_CODE_TRANSCRIPTION[request.fromWallet.currencyInfo.pluginId] ==
-        null ||
-      MAINNET_CODE_TRANSCRIPTION[request.toWallet.currencyInfo.pluginId] == null
-    ) {
-      throw new SwapCurrencyError(swapInfo, request)
-    }
-
     const {
       fromCurrencyCode,
       toCurrencyCode,
@@ -376,6 +368,11 @@ export function makeChangeHeroPlugin(
     async fetchSwapQuote(req: EdgeSwapRequest): Promise<EdgeSwapQuote> {
       const request = convertRequest(req)
       checkInvalidCodes(INVALID_CURRENCY_CODES, request, swapInfo)
+      checkWhitelistedMainnetCodes(
+        MAINNET_CODE_TRANSCRIPTION,
+        request,
+        swapInfo
+      )
 
       const newRequest = await getMaxSwappable(getFixedQuote, request)
       const swapOrder = await getFixedQuote(newRequest)

diff --git a/src/swap/central/changenow.ts b/src/swap/central/changenow.ts
@@ -22,6 +22,7 @@ import {
 
 import {
   checkInvalidCodes,
+  checkWhitelistedMainnetCodes,
   ensureInFuture,
   getCodesWithTranscription,
   getMaxSwappable,
@@ -397,6 +398,11 @@ export function makeChangeNowPlugin(
       const request = convertRequest(req)
 
       checkInvalidCodes(INVALID_CURRENCY_CODES, request, swapInfo)
+      checkWhitelistedMainnetCodes(
+        MAINNET_CODE_TRANSCRIPTION,
+        request,
+        swapInfo
+      )
 
       const newRequest = await getMaxSwappable(
         fetchSwapQuoteInner,

diff --git a/src/swap/central/exolix.ts b/src/swap/central/exolix.ts
@@ -21,6 +21,7 @@ import {
 
 import {
   checkInvalidCodes,
+  checkWhitelistedMainnetCodes,
   getCodesWithTranscription,
   getMaxSwappable,
   InvalidCurrencyCodes,
@@ -345,6 +346,11 @@ export function makeExolixPlugin(opts: EdgeCorePluginOptions): EdgeSwapPlugin {
       const request = convertRequest(req)
 
       checkInvalidCodes(INVALID_CURRENCY_CODES, request, swapInfo)
+      checkWhitelistedMainnetCodes(
+        MAINNET_CODE_TRANSCRIPTION,
+        request,
+        swapInfo
+      )
 
       const newRequest = await getMaxSwappable(
         getFixedQuote,

diff --git a/src/swap/central/godex.ts b/src/swap/central/godex.ts
@@ -22,6 +22,7 @@ import {
 
 import {
   checkInvalidCodes,
+  checkWhitelistedMainnetCodes,
   getCodesWithTranscription,
   getMaxSwappable,
   InvalidCurrencyCodes,
@@ -363,6 +364,11 @@ export function makeGodexPlugin(opts: EdgeCorePluginOptions): EdgeSwapPlugin {
     ): Promise<EdgeSwapQuote> {
       const request = convertRequest(req)
       checkInvalidCodes(INVALID_CURRENCY_CODES, request, swapInfo)
+      checkWhitelistedMainnetCodes(
+        MAINNET_CODE_TRANSCRIPTION,
+        request,
+        swapInfo
+      )
 
       const newRequest = await getMaxSwappable(
         fetchSwapQuoteInner,

diff --git a/src/swap/central/letsexchange.ts b/src/swap/central/letsexchange.ts
@@ -15,6 +15,7 @@ import {
 
 import {
   checkInvalidCodes,
+  checkWhitelistedMainnetCodes,
   CurrencyCodeTranscriptionMap,
   getCodesWithTranscription,
   getMaxSwappable,
@@ -370,6 +371,11 @@ export function makeLetsExchangePlugin(
     ): Promise<EdgeSwapQuote> {
       const request = convertRequest(req)
       checkInvalidCodes(INVALID_CURRENCY_CODES, request, swapInfo)
+      checkWhitelistedMainnetCodes(
+        MAINNET_CODE_TRANSCRIPTION,
+        request,
+        swapInfo
+      )
 
       const newRequest = await getMaxSwappable(
         fetchSwapQuoteInner,

diff --git a/src/swap/central/sideshift.ts b/src/swap/central/sideshift.ts
@@ -16,6 +16,7 @@ import {
 
 import {
   checkInvalidCodes,
+  checkWhitelistedMainnetCodes,
   ensureInFuture,
   getCodesWithTranscription,
   getMaxSwappable,
@@ -322,6 +323,7 @@ const createFetchSwapQuote = (api: SideshiftApi, affiliateId: string) =>
   async function fetchSwapQuote(req: EdgeSwapRequest): Promise<EdgeSwapQuote> {
     const request = convertRequest(req)
     checkInvalidCodes(INVALID_CURRENCY_CODES, request, swapInfo)
+    checkWhitelistedMainnetCodes(MAINNET_CODE_TRANSCRIPTION, request, swapInfo)
 
     const newRequest = await getMaxSwappable(
       fetchSwapQuoteInner,

diff --git a/src/swap/central/swapuz.ts b/src/swap/central/swapuz.ts
@@ -21,6 +21,7 @@ import {
 import { div18 } from '../../util/biggystringplus'
 import {
   checkInvalidCodes,
+  checkWhitelistedMainnetCodes,
   ensureInFuture,
   getCodesWithTranscription,
   getMaxSwappable,
@@ -138,6 +139,7 @@ export function makeSwapuzPlugin(opts: EdgeCorePluginOptions): EdgeSwapPlugin {
     const { fromWallet, toWallet } = request
 
     checkInvalidCodes(INVALID_CURRENCY_CODES, request, swapInfo)
+    checkWhitelistedMainnetCodes(MAINNET_CODE_TRANSCRIPTION, request, swapInfo)
 
     // Grab addresses:
     const [fromAddress, toAddress] = await Promise.all([

diff --git a/src/util/swapHelpers.ts b/src/util/swapHelpers.ts
@@ -13,7 +13,7 @@ import {
   SwapCurrencyError
 } from 'edge-core-js/types'
 
-import { EdgeSwapRequestPlugin, MakeTxParams } from '../swap/types'
+import { EdgeSwapRequestPlugin, MakeTxParams, StringMap } from '../swap/types'
 
 const likeKindAssets = [
   ['BTC', 'WBTC', 'SBTC', 'RBTC'],
@@ -375,6 +375,19 @@ export function checkInvalidCodes(
     throw new SwapCurrencyError(swapInfo, request)
 }
 
+export const checkWhitelistedMainnetCodes = (
+  whitelist: StringMap,
+  request: EdgeSwapRequest,
+  swapInfo: EdgeSwapInfo
+): void => {
+  if (
+    whitelist[request.fromWallet.currencyInfo.pluginId] == null ||
+    whitelist[request.toWallet.currencyInfo.pluginId] == null
+  ) {
+    throw new SwapCurrencyError(swapInfo, request)
+  }
+}
+
 export interface CurrencyCodeTranscriptions {
   [code: string]: {
     [code: string]: string