Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Thorchain give estimate quotes #296

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Make Thorchain give estimate quotes #296

merged 1 commit into from
Oct 24, 2023

Conversation

paullinator
Copy link
Member

@paullinator paullinator commented Oct 19, 2023 •
edited
Loading

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

  • Yes
  • No

Dependencies

none

Description

none

@paullinator paullinator force-pushed the paul/tcEstimateQuotes branch 2 times, most recently from fdefabf to 727ea4c Compare October 19, 2023 05:04
peachbits
peachbits approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@peachbits peachbits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine but I don't understand the rationale of keeping the non-estimate code flows that can't be used. There's no justification in this PR or the associated asana task and the changelog entry implies it's permanent.

@paullinator
Copy link
Member Author

This seems fine but I don't understand the rationale of keeping the non-estimate code flows that can't be used. There's no justification in this PR or the associated asana task and the changelog entry implies it's permanent.

The justification in keeping the fixed rate flows is for when we can export both quotes and to let the user choose.

@paullinator
Copy link
Member Author

/rebase

@github-actions github-actions bot force-pushed the paul/tcEstimateQuotes branch from 727ea4c to 1d7f1f9 Compare October 24, 2023 16:53
@paullinator paullinator force-pushed the paul/tcEstimateQuotes branch from 1d7f1f9 to ea9599f Compare October 24, 2023 16:58
@paullinator paullinator merged commit be3e708 into master Oct 24, 2023
1 check passed
@paullinator paullinator deleted the paul/tcEstimateQuotes branch October 24, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peachbits peachbits peachbits approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paullinator @peachbits