Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spend target native amount #299

Merged
merged 2 commits into from
Nov 8, 2023
Merged

Conversation

peachbits
Copy link
Contributor

@peachbits peachbits commented Oct 31, 2023

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

  • Yes
  • No

Dependencies

none

Description

none

@peachbits peachbits force-pushed the matthew/fixSpendTargetAmount branch from 090ce6a to e2f962e Compare October 31, 2023 19:59
…opulated Ethers transaction

The value field cannot be relied upon for token transactions since, generally, this field is used for mainnet ETH amount. Instead, we should use the amount we pass to Ethers as the nativeAmount. We also need to account for the fact that in the case where there are two transactions the first one is a 0 amount approval tx and only the second one needs the amount.
@peachbits peachbits force-pushed the matthew/fixSpendTargetAmount branch from e2f962e to 92ac078 Compare November 8, 2023 07:34
@peachbits peachbits enabled auto-merge November 8, 2023 07:34
@peachbits peachbits merged commit 0ae93d7 into master Nov 8, 2023
1 check passed
@peachbits peachbits deleted the matthew/fixSpendTargetAmount branch November 8, 2023 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants