Lifi: Add Solana support #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swansontec
approved these changes
Jun 17, 2024
src/swap/defi/lifi.ts
Outdated
| @@ -133,7 +140,7 @@ const asEstimate = asObject({ | |||
| // feeCosts: asArray(asFeeCost) | |||
| }) | |||
|
|
|||
| const asTransactionRequest = asObject({ | |||
| const asTransactionReques = asObject({ | |||
There was a problem hiding this comment.
asTransactionReques is a bad name.
| @@ -319,6 +325,51 @@ export function makeLifiPlugin(opts: EdgeCorePluginOptions): EdgeSwapPlugin { | |||
| let preTx: EdgeTransaction | undefined | |||
| let spendInfo: EdgeSpendInfo | |||
| switch (fromWallet.currencyInfo.pluginId) { | |||
| case 'solana': { | |||
There was a problem hiding this comment.
I see. We don't do token approvals on Solana, so this has to be pretty different.
peachbits
force-pushed
the
matthew/solanaLifi
branch
from
3820f60
to
2d1b0bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
EdgeApp/edge-currency-accountbased#785
Description
none