Implement 0xgasless swap #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 25, 2024
swansontec
approved these changes
Jun 25, 2024
src/swap/defi/0x/0xGasless.ts
Outdated
| const orderId = apiSwapSubmition.tradeHash | ||
| const { | ||
| publicAddress: toWalletAddress | ||
| } = await swapRequest.toWallet.getReceiveAddress({ |
There was a problem hiding this comment.
This is really freaking me out. We never seem to request an address from the toWallet before this line, so how on earth are the funds arriving there? It seems like the gasless swaps are only within the same wallet, so do we need to add a toWallet.id === fromWallet.id check?
samholmes
force-pushed
the
sam/0xgasless
branch
2 times, most recently
from
f5510c4
to
88fc25c
Compare
Fee is paid out of the fromToken amount, so in other words, the exchange rate is adjusted to account for the fee. This means the user will always expect to pay the `nativeAmount` with no fee, but this does impact the exchange rate used to calculate the buy-token (to-token) amount.
swansontec
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneDescription
none