Use data from quote response #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peachbits
force-pushed
the
matthew/swapkit-evm-data
branch
from
a81141e to
f582a00
Compare
paullinator
approved these changes
Dec 31, 2024
paullinator
approved these changes
Dec 31, 2024
src/swap/defi/thorchain/swapkit.ts
Outdated
| @@ -92,6 +89,9 @@ const asThorSwapRoute = asObject({ | |||
| // expectedOutputMaxSlippage: asString, | |||
| // expectedOutputUSD: asString, | |||
| // expectedOutputMaxSlippageUSD: asString, | |||
| transaction: asObject({ | |||
There was a problem hiding this comment.
Are you for sure sure that this isn't optional. There may not be a data payload for some types of swaps? Just make sure to test that this is true when sending EVM, UTXO, and Solana (if supported)
There was a problem hiding this comment.
Good catch! It's not there for UTXO. I added a fixup commit
peachbits
force-pushed
the
matthew/swapkit-evm-data
branch
from
f582a00 to
aeb0969
Compare
paullinator
approved these changes
Jan 9, 2025
The data blob probably wasn't available in the quote response when swapkit was first implemented. I verified it's the same data we would have created using getCalldataData
peachbits
force-pushed
the
matthew/swapkit-evm-data
branch
from
aeb0969 to
95f18a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneDescription
none